Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade of Surefire and Failsafe plugins to 3.0.0-M3 #149

Merged
merged 2 commits into from
Jan 15, 2019
Merged

Upgrade of Surefire and Failsafe plugins to 3.0.0-M3 #149

merged 2 commits into from
Jan 15, 2019

Conversation

antoinell
Copy link
Contributor

@antoinell antoinell commented Jan 10, 2019 •
edited
Loading

SUREFIRE-1541's symptom was :
SurefireBooterForkException: The forked VM terminated without properly saying goodbye. VM crash or System.exit called?
happening when building the amazon-ecs-plugin with

  • Maven 3.5.2
  • openjdk version "1.8.0_181"
    OpenJDK Runtime Environment (build 1.8.0_181-8u181-b13-1ubuntu0.18.04.1-b13)
    OpenJDK 64-Bit Server VM (build 25.181-b13, mixed mode)

We will be able to remove the SUREFIRE-1588 workaround as well

@antoinell
The objective is to fix the following issues :
7eb71f7 
 -  SUREFIRE-1541,
 -  SUREFIRE-1588,
 -  SUREFIRE-1608

SUREFIRE-1541's symptom was :
SurefireBooterForkException: The forked VM terminated without properly saying goodbye. VM crash or System.exit called?
happening when building the amazon-ecs-plugin with
- Maven 3.5.2
- openjdk version "1.8.0_181"
OpenJDK Runtime Environment (build 1.8.0_181-8u181-b13-1ubuntu0.18.04.1-b13)
OpenJDK 64-Bit Server VM (build 25.181-b13, mixed mode)

We will be able to remove the SUREFIRE-1588 workaround as well
@antoinell
Copy link
Contributor Author

This pull request replaces #145 .

@antoinell
Copy link
Contributor Author

@batmat if you create another snapshot with this version I will be able to create another test PR tonight.

@batmat
Copy link
Member

batmat commented Jan 10, 2019

7eb71f7a3efae514561135567685d1b394af6ab7 deployed as 3.33-20190110.132338-3

@jglick jglick mentioned this pull request Jan 10, 2019
Closed
@jglick jglick requested a review from batmat January 10, 2019 14:21
@jglick
Copy link
Member

jglick commented Jan 10, 2019

We will be able to remove the SUREFIRE-1588 workaround as well

So, do so please! (#135 for example)

@jglick
Copy link
Member

jglick commented Jan 10, 2019

  • SUREFIRE-1541,
  • SUREFIRE-1588,
  • SUREFIRE-1608

BTW please hyperlink these for the convenience of reviewers.

@jglick jglick self-requested a review January 10, 2019 14:24
batmat
batmat approved these changes Jan 11, 2019
View reviewed changes
Copy link
Member

@batmat batmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM given apparently there's currently only two open issues on 3.0.0-M3

And both look like they would not impact us: (JUnit 5 related, not an issue yet for us)

antoinell added a commit to antoinell/git-plugin that referenced this pull request Jan 11, 2019
@antoinell
Test for PR jenkinsci/plugin-pom#149
dd7e0a4
@antoinell antoinell mentioned this pull request Jan 11, 2019
Closed
@antoinell
Copy link
Contributor Author

@batmat @jglick I created this PR jenkinsci/git-plugin#659 to test the snapshot created by @batmat.

@antoinell
Copy link
Contributor Author

@jglick I removed the workaround for SUREFIRE-1588 as in #135 and hyperlinked the three SUREFIRE issues mentioned in the PR description.

@antoinell
Copy link
Contributor Author

@batmat @jglick is this pull request going to be merged now ?

@oleg-nenashev oleg-nenashev merged commit 632afd3 into jenkinsci:master Jan 15, 2019
@oleg-nenashev
Copy link
Member

Thanks @antoinell !

@antoinell
Copy link
Contributor Author

Thanks @oleg-nenashev @batmat @jglick .
What would be good now would be to make a release of plugin-pom - I suppose it will be 3.33 and upgrade the master branch of as many plugins as possible to refer to this new parent. I had originally ec2-plugin in my sights.

@antoinell antoinell deleted the surefireM3 branch January 16, 2019 02:07
@oleg-nenashev
Copy link
Member

I will check with @alecharp today about #148 . If he is available to finalize it, we will release them in a same version. Otherwise I will get this PR released today

@jglick jglick mentioned this pull request Jun 19, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleg-nenashev oleg-nenashev oleg-nenashev approved these changes

@batmat batmat batmat approved these changes

@jglick jglick jglick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@antoinell @batmat @jglick @oleg-nenashev