Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-60474] streamline the pom and support the jenkins-bom #269

Merged
merged 36 commits into from
Dec 24, 2019

Commits on Dec 13, 2019

  1. Configuration menu
    Copy the full SHA
    e5b32d4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a0be78d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9ca3bdb View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2019

  1. Configuration menu
    Copy the full SHA
    fdc501e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0b4fdac View commit details
    Browse the repository at this point in the history
  3. findbugs is dead

    jtnord committed Dec 16, 2019
    Configuration menu
    Copy the full SHA
    09cde37 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    38a5f3c View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    320374a View commit details
    Browse the repository at this point in the history
  6. there is no excuse for allowing evry single plugin to have falky tests.

    Plugins that have flaky tests due to infra requirements etc should opt
    in to this.
    jtnord committed Dec 16, 2019
    Configuration menu
    Copy the full SHA
    4569982 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    50bfd73 View commit details
    Browse the repository at this point in the history
  8. inline trimStackTrace and add failsafe to the build.

    Adding failsafe allows people to write JenkinsRule style tests as ITs so
    that they can easily run normal unit tests and git quicker feedback in
    isolation from failsafe style tests with slower feedback should they
    desire.
    
    jacoco needs to be bound to its default verify in order to pick up
    coverage from IT tests
    jtnord committed Dec 16, 2019
    Configuration menu
    Copy the full SHA
    11afd7d View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    f21e6cb View commit details
    Browse the repository at this point in the history
  10. remove support for jgit provider

    installing and configuring git should be pretty simple.
    jtnord committed Dec 16, 2019
    Configuration menu
    Copy the full SHA
    1115636 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    9afd792 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    5efade2 View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2019

  1. enforce no snapshots for releases.

    WHilst the m-r-p should do this there are occaisons where it does not,
    and we do not actually force people to release with the m-r-p
    jtnord committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    755371c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    97cabd7 View commit details
    Browse the repository at this point in the history
  3. remove old animal sniffer versions we only need to support 1.8 or newer

    (but in reality it is just 1.8)
    jtnord committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    367d4e9 View commit details
    Browse the repository at this point in the history
  4. you can not activate profiles based on properties defined in a project

    thus this profile was as much use as a chocolate fire guard and has been
    terminated with extreme prejudice
    jtnord committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    48070e4 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2019

  1. tidy up some comments

    jtnord committed Dec 18, 2019
    Configuration menu
    Copy the full SHA
    a498d8a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b28f137 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2e284e7 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    793f39f View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    3e62514 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2019

  1. Configuration menu
    Copy the full SHA
    586d740 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2019

  1. turns out the executable-war is magic.

    without it JenkinsRule tests fail with things like
    
    ```
      26.565 [id=86]        WARNING
      h.ExtensionFinder$GuiceFinder$FaultTolerantScope$1#error: Failed to
      instantiate Key[type=jenkins.slaves.JnlpSlaveAgentProtocol4,
      annotation=[none]]; skipping this component
      java.security.KeyStoreException: JENKINS-41987: no X509Certificate
      found; perhaps instance-identity module is missing or too old
      at
      jenkins.slaves.JnlpSlaveAgentProtocol4.<init>(JnlpSlaveAgentProtocol4.java:105)
      at
      jenkins.slaves.JnlpSlaveAgentProtocol4$$FastClassByGuice$$b470638c.newInstance(<generated>)
      at
      com.google.inject.internal.cglib.reflect.$FastConstructor.newInstance(FastConstructor.java:40)
      at
      com.google.inject.internal.DefaultConstructionProxyFactory$1.newInstance(DefaultConstructionProxyFactory.java:61)
      at
      com.google.inject.internal.ConstructorInjector.provision(ConstructorInjector.java:105)
      at
      com.google.inject.internal.ConstructorInjector.access$000(ConstructorInjector.java:32)
      at
      com.google.inject.internal.ConstructorInjector$1.call(ConstructorInjector.java:89)
      at
      com.google.inject.internal.ProvisionListenerStackCallback$Provision.provision(ProvisionListenerStackCallback.java:115)
      at
      hudson.ExtensionFinder$GuiceFinder$SezpozModule.onProvision(ExtensionFinder.java:567)
      at
      com.google.inject.internal.ProvisionListenerStackCallback$Provision.provision(ProvisionListenerStackCallback.java:126)
      at
      com.google.inject.internal.ProvisionListenerStackCallback.provision(ProvisionListenerStackCallback.java:68)
      at
      com.google.inject.internal.ConstructorInjector.construct(ConstructorInjector.java:87)
      at
      com.google.inject.internal.ConstructorBindingImpl$Factory.get(ConstructorBindingImpl.java:267)
      at
      com.google.inject.internal.ProviderToInternalFactoryAdapter$1.call(ProviderToInternalFactoryAdapter.java:46)
      at
      com.google.inject.internal.InjectorImpl.callInContext(InjectorImpl.java:1103)
      at
      com.google.inject.internal.ProviderToInternalFactoryAdapter.get(ProviderToInternalFactoryAdapter.java:40)
      Caused: com.google.inject.ProvisionException: Unable to provision, see
      the following errors:
      1) Error injecting constructor, java.security.KeyStoreException:
      JENKINS-41987: no X509Certificate found; perhaps instance-identity
      module is missing or too old
      at
      jenkins.slaves.JnlpSlaveAgentProtocol4.<init>(JnlpSlaveAgentProtocol4.java:101)
      1 error
      at
      com.google.inject.internal.ProviderToInternalFactoryAdapter.get(ProviderToInternalFactoryAdapter.java:52)
      at
      com.google.inject.internal.SingletonScope$1.get(SingletonScope.java:145)
      at
      hudson.ExtensionFinder$GuiceFinder$FaultTolerantScope$1.get(ExtensionFinder.java:439)
      at
      com.google.inject.internal.InternalFactoryToProviderAdapter.get(InternalFactoryToProviderAdapter.java:41)
      at
      com.google.inject.internal.InjectorImpl$2$1.call(InjectorImpl.java:1016)
      at
      com.google.inject.internal.InjectorImpl.callInContext(InjectorImpl.java:1092)
      at
      com.google.inject.internal.InjectorImpl$2.get(InjectorImpl.java:1012)
      at hudson.ExtensionFinder$GuiceFinder._find(ExtensionFinder.java:401)
      at hudson.ExtensionFinder$GuiceFinder.find(ExtensionFinder.java:392)
      at
      hudson.ClassicPluginStrategy.findComponents(ClassicPluginStrategy.java:344)
      at hudson.ExtensionList.load(ExtensionList.java:381)
      at hudson.ExtensionList.ensureLoaded(ExtensionList.java:317)
      at hudson.ExtensionList.iterator(ExtensionList.java:172)
      at jenkins.AgentProtocol.of(AgentProtocol.java:112)
      at
      hudson.TcpSlaveAgentListener$ConnectionHandler.run(TcpSlaveAgentListener.java:284)
    ```
    jtnord committed Dec 20, 2019
    Configuration menu
    Copy the full SHA
    7dc1c18 View commit details
    Browse the repository at this point in the history

Commits on Dec 23, 2019

  1. Configuration menu
    Copy the full SHA
    bb4f3e2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    642ef9d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d246f1c View commit details
    Browse the repository at this point in the history
  4. just activate the benchmark profile with a standard profile activation

    Do not use a property to activate a profile, just activate the profile
    directly
    jtnord committed Dec 23, 2019
    Configuration menu
    Copy the full SHA
    59018c0 View commit details
    Browse the repository at this point in the history
  5. Update README

    jtnord committed Dec 23, 2019
    Configuration menu
    Copy the full SHA
    bf90d59 View commit details
    Browse the repository at this point in the history
  6. change version to 4.0-beta-1-SNAPSHOT

    Co-Authored-By: Oleg Nenashev <o.v.nenashev@gmail.com>
    jtnord and oleg-nenashev committed Dec 23, 2019
    Configuration menu
    Copy the full SHA
    15e346f View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    19dab6c View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    8c9203c View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    b9b10c3 View commit details
    Browse the repository at this point in the history

Commits on Dec 24, 2019

  1. Configuration menu
    Copy the full SHA
    c13f626 View commit details
    Browse the repository at this point in the history