Avoid MCOMPILER-485 in compiler plugin 3.10.0

[MarkEWaite]

Avoid MCOMPILER-485 in compiler plugin 3.10.0

Maven 3.10.0 added a feature to create missing package-info files. The feature incorrectly uses Windows-style directory separators on Windows. Other parts of the code expect to always see Unix style directory separators.

Disable the new feature so that it does not break compilation. See Jenkins developer mailing list conversation for details.

• Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
• Ensure that the pull request title represents the desired changelog entry
• Please describe what you did
• Link to relevant issues in GitHub or Jira
• Link to relevant pull requests, esp. upstream and downstream changes
• Ensure you have provided tests - that demonstrates feature works or fixes the issue

I'm not expert enough in Maven development to create the integration test to confirm the issue is resolved. I assume it would require a Java package that does not have a package-info file and then a check on Windows that some internal path to the generated package-info file is using Windows directory separators.

[jglick]

Amending #504.

[jglick]

Does this fix the problem in git-plugin?

[timja]

I see the fix is merged, @olamy will it be released soon? ❤️

[olamy]

I see the fix is merged, @olamy will it be released soon? ❤️

does this break Jenkins build or not? (sorry I do not have windauze to test that)
if yes simply configure the the m-c-p parameter createMissingPackageInfoClass to false (https://maven.apache.org/plugins/maven-compiler-plugin/compile-mojo.html#createMissingPackageInfoClass)

As Jenkins is not yet build with Java 11 (neither using really soon jpms features) there is probably nothing urgent here ;)

[olamy]

LOL I did not even read the content of the PR but only the comment 🤣
so all good job by @MarkEWaite

[jglick]

@olamy any idea when apache/maven-compiler-plugin#95 will be released?

[jglick]

Released this as 4.36, along with a mojo fix from @basil.