Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade htmlunit to 3.3.0 #777

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 4, 2023

Bumps jenkins-test-harness from 2007.v8f9e5c18335a_ to 2010.v1888f1a_cd45a_.

Release notes

Sourced from jenkins-test-harness's releases.

2010.v1888f1a_cd45a_

💥 Breaking changes

🚦 Tests

📦 Dependency updates

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @timja.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [jenkins-test-harness](https://github.com/jenkinsci/jenkins-test-harness) from 2007.v8f9e5c18335a_ to 2010.v1888f1a_cd45a_.
- [Release notes](https://github.com/jenkinsci/jenkins-test-harness/releases)
- [Changelog](https://github.com/jenkinsci/jenkins-test-harness/blob/master/docs/CHANGELOG-OLD.md)
- [Commits](https://github.com/jenkinsci/jenkins-test-harness/commits)

---
updated-dependencies:
- dependency-name: org.jenkins-ci.main:jenkins-test-harness
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jun 4, 2023
@timja timja added the breaking label Jun 4, 2023
@timja timja changed the title Bump jenkins-test-harness from 2007.v8f9e5c18335a_ to 2010.v1888f1a_cd45a_ Upgrade htmlunit to 3.3.0 Jun 4, 2023
@timja
Copy link
Member

timja commented Jun 4, 2023

@dependabot squash and merge

@dependabot dependabot bot merged commit 71ee49c into master Jun 4, 2023
@dependabot dependabot bot deleted the dependabot/maven/org.jenkins-ci.main-jenkins-test-harness-2010.v1888f1a_cd45a_ branch June 4, 2023 20:51
Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not

<exclude>com/gargoylesoftware/**</exclude>
also need to be updated in lockstep with this change?

@timja
Copy link
Member

timja commented Jun 6, 2023

Does not

<exclude>com/gargoylesoftware/**</exclude>

also need to be updated in lockstep with this change?

From my reading it's actually dead code as the bug was fixed, I would have expected to have hit the issue by now if it was still necessary so I'll file a PR to remove it.

Apparently there's another parser that says it's been fixed but HtmlUnit is using the the original project.

I checked in workflow-job where there was originally seen and it's still an issue, (although just causing log spam).

dTooLargeException: Method too large: org/htmlunit/css/StyleAttributes$Definition.<clinit> ()V
	at org.jacoco.agent.rt.internal_4a7f17c.asm.MethodWriter.computeMethodInfoSize(MethodWriter.java:2088)
	at org.jacoco.agent.rt.internal_4a7f17c.asm.ClassWriter.toByteArray(ClassWriter.java:511)
	at org.jacoco.agent.rt.internal_4a7f17c.core.instr.Instrumenter.instrument(Instrumenter.java:92)
	at org.jacoco.agent.rt.internal_4a7f17c.core.instr.Instrumenter.instrument(Instrumenter.java:109)
	... 55 more

@timja timja mentioned this pull request Jun 6, 2023
6 tasks
@timja
Copy link
Member

timja commented Jun 6, 2023

👉 #778

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants