Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't set stupid defaults. #80

Merged
merged 1 commit into from
Oct 17, 2017
Merged

Don't set stupid defaults. #80

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,8 @@
<!-- Change this property if you need your tests to be compiled with a different Java level than the plugin. -->
<!-- Use only if strictly necessary. It may cause problems in your IDE. -->
<java.level.test>${java.level}</java.level.test>
<concurrency>1</concurrency> <!-- may use e.g. 2C for 2 × (number of cores) -->
<concurrency>1</concurrency> <!-- DEPRECATED use forkCount -->
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure we even need this but it here for backwards compatability... happy to remove both this and forkCount (as the default is one...)

<forkCount>${concurrency}</forkCount> <!-- may use e.g. 2C for 2 × (number of cores) -->
<trimStackTrace>false</trimStackTrace> <!-- SUREFIRE-1226 workaround -->
<!-- Whether the build should fail if findbugs finds any error. -->
<!-- It is strongly encouraged to leave it as true. Use false with care only in transient situations. -->
Expand Down Expand Up @@ -689,11 +690,9 @@
<systemProperties>
<property>
<name>hudson.udp</name>
<value>33849</value>
<value>-1</value>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean why would we want this... like EVER? (if some esoteric plugin needs it for a test then let them configure it?)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UDP disabling without throwing errors was only added in 1.514: jenkinsci/jenkins@19f34b5

This option is set at least since 1.388: https://github.com/jenkinsci/jenkins/blob/ea06f60c1abe408ccb45c700421c0456ce00ef6d/plugins/pom.xml#L196, probably a lot longer.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daniel-beck that's a novel use of "only" - something that happened more than 4 years ago :-)

do you care about that supporting building plugins for something as old as that?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just answering your comment. This didn't disable, because disabling didn't exist.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine, though better to just move the code out of core, as is already filed in a split-plugins-from-core issue.

</property>
</systemProperties>
<reuseForks>true</reuseForks>
<forkCount>${concurrency}</forkCount>
</configuration>
</plugin>
<plugin>
Expand Down