Remove source=8 from Javadoc configuration
#268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Amends #209. Setting
source=8is wrong now that we are requiring Java 11. Furthermore, based on my reading ofAbstractJavadocMojoit is dead code: wheneverreleaseis set, it is always used in place ofsourcein that class. And we are (implicitly) settingrelease(to the correct value of 11, no less!) becausereleasedefaults to the value of themaven.compiler.releaseproperty, which we are setting to 11. So we are implicitly settingrelease, which meanssourceis unused, which means it is dead code, which means it should be deleted.