Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate SpotBugs defaults #333

Merged
merged 2 commits into from
Nov 2, 2022
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 0 additions & 17 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -85,18 +85,6 @@

<spotbugs-maven-plugin.version>4.7.2.1</spotbugs-maven-plugin.version>
<spotbugs-annotations.version>4.7.3</spotbugs-annotations.version>
<!-- Whether the build should fail if SpotBugs finds any error. -->
<!-- It is strongly encouraged to leave it as true. Use false with care only in transient situations. -->
<spotbugs.failOnError>true</spotbugs.failOnError>
<!-- Defines a SpotBugs threshold. Use "Low" to discover low-priority bugs.
Hint: SpotBugs considers some real NPE risks in Jenkins as low-priority issues, it is recommended to enable it in plugins.
-->
<spotbugs.threshold>Medium</spotbugs.threshold>
<!-- Defines a SpotBugs effort. Use "Max" to maximize the scan depth -->
<spotbugs.effort>default</spotbugs.effort>
<!-- Defines an optional SpotBugs excludes file.
Generally it is recommended to use @SuppressFBWarnings annotation unless you want to ignore an entire class of issues -->
<spotbugs.excludeFilterFile />

<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
<project.build.outputEncoding>UTF-8</project.build.outputEncoding>
Expand Down Expand Up @@ -680,13 +668,8 @@
<groupId>com.github.spotbugs</groupId>
<artifactId>spotbugs-maven-plugin</artifactId>
<configuration>
<failOnError>${spotbugs.failOnError}</failOnError>
<xmlOutput>true</xmlOutput>
<spotbugsXmlOutput>false</spotbugsXmlOutput>
<effort>${spotbugs.effort}</effort>
<threshold>${spotbugs.threshold}</threshold>
<!-- Empty by default, child POMs are expected to override if needed -->
<excludeFilterFile>${spotbugs.excludeFilterFile}</excludeFilterFile>
<plugins>
<plugin>
<groupId>com.h3xstream.findsecbugs</groupId>
Expand Down