Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable incremental builds #334

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Conversation

basil
Copy link
Member

@basil basil commented Nov 2, 2022

Like jenkinsci/plugin-pom#627 but for core and core components. The intended use case of this is to be able to more easily test PR builds of this repository in realistic use cases, albeit with the additional effort of adding a custom <repository>.

Testing done

Compared the differential between the partially flattened (new) https://repo.jenkins-ci.org/incrementals/org/jenkins-ci/jenkins/1.91-rc788.75b_1a_eca_b_8b_5/jenkins-1.91-rc788.75b_1a_eca_b_8b_5.pom and the unflattened (old) https://repo.jenkins-ci.org/public/org/jenkins-ci/jenkins/1.90/jenkins-1.90.pom and did not see anything of concern. I encourage reviewers to look at this differential for themselves. The only changes seem to be that properties seem to be in a random order (probably going through some HashMap internally somewhere) and the elements of the POM have been re-ordered according to the POM Code Convention (which we could re-order in the main branch if we wanted to reduce the diff even further).

Verified that I could successfully consume the resulting incremental build in Swarm Client by running mvn clean verify -DskipTests with

diff --git a/client/pom.xml b/client/pom.xml
index 00a3f34..999ec72 100644
--- a/client/pom.xml
+++ b/client/pom.xml
@@ -4,7 +4,7 @@
     <parent>
         <groupId>org.jenkins-ci</groupId>
         <artifactId>jenkins</artifactId>
-        <version>1.90</version>
+        <version>1.91-rc788.75b_1a_eca_b_8b_5</version>
         <relativePath />
     </parent>
 
@@ -88,6 +88,13 @@
             <id>repo.jenkins-ci.org</id>
             <url>https://repo.jenkins-ci.org/public/</url>
         </repository>
+        <repository>
+            <snapshots>
+                <enabled>false</enabled>
+            </snapshots>
+            <id>incrementals</id>
+            <url>https://repo.jenkins-ci.org/incrementals/</url>
+        </repository>
     </repositories>
 
     <pluginRepositories>

@basil basil requested a review from jglick November 2, 2022 21:47
@basil basil marked this pull request as draft December 26, 2022 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants