Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete Maven plugins #375

Merged
merged 2 commits into from
Jan 19, 2023
Merged

Remove obsolete Maven plugins #375

merged 2 commits into from
Jan 19, 2023

Conversation

basil
Copy link
Member

@basil basil commented Jan 19, 2023

This POM includes a number of Maven plugins that are not present in the plugin POM, are not consumed by Jenkins core or any Jenkins core components, and which are obsolete and have not been released in years. This is a maintenance burden, so this PR removes them. In the unlikely case that any consumers still needs one of these Maven plugins, they can declare its version themselves rather than getting it from the parent POM. To test this PR I successfully compiled Jenkins core with these changes.

@basil basil added the removed label Jan 19, 2023
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed that if an unexpected use is detected in a downstream component, that component can declare the version number or can decide to drop the maven plugin that has the dependency

@basil basil merged commit cec622a into jenkinsci:master Jan 19, 2023
@basil basil deleted the slim branch January 19, 2023 21:17
@basil basil mentioned this pull request Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants