Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-74012] Extract JavaScript block from SourceCodeViewModel/index.jelly #181

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

yaroslavafenkin
Copy link
Contributor

https://issues.jenkins.io/browse/JENKINS-74012

Testing done

Configured a pipeline that intentionally has CheckStyle violations and built it. Went to the CheckStyle warnings report, clicked on a violation that's on the lowest available line, so we can also see the scrolling behavior.

Before the change
After the change

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.71%. Comparing base (d183c39) to head (6320423).
Report is 51 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #181      +/-   ##
============================================
+ Coverage     75.39%   75.71%   +0.31%     
- Complexity       93       95       +2     
============================================
  Files            13       13              
  Lines           378      387       +9     
  Branches         30       31       +1     
============================================
+ Hits            285      293       +8     
- Misses           90       91       +1     
  Partials          3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@basil basil requested a review from uhafner November 6, 2024 21:34
@uhafner uhafner added bug Bugs or performance problems internal Internal changes without user or API impact and removed bug Bugs or performance problems labels Nov 11, 2024
@uhafner uhafner merged commit fabff45 into jenkinsci:main Nov 11, 2024
33 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Internal changes without user or API impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants