Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JEP-200] Save charset names, not actual Charset objects #2

Merged
merged 4 commits into from
Jan 13, 2018

Conversation

jglick
Copy link
Member

@jglick jglick commented Jan 11, 2018

See jenkinsci/jenkins#3120. Note that

  • DescriptionSetterWrapperDescriptor was already doing the right thing.
  • The current getter is not right—should return .name(), not .displayName().
  • This patch does not address old saved settings, which would presumably block the wrapper from loading. You would need to resave the project before updating Jenkins. Fixing that would be hard—would need a custom XStream Converter, I think.

@reviewbybees

@ghost
Copy link

ghost commented Jan 11, 2018

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐝

@jglick
Copy link
Member Author

jglick commented Jan 12, 2018

@reviewbybees done

@oleg-nenashev
Copy link
Member

Created a request to get temporary ownership of the plugin: https://groups.google.com/forum/#!topic/jenkinsci-dev/scG6cjRCqxY

@oleg-nenashev oleg-nenashev merged commit ff44c15 into jenkinsci:master Jan 13, 2018
@jglick jglick deleted the JEP-200 branch January 17, 2018 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants