Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hamcrest #241

Merged
merged 2 commits into from
Jun 22, 2023
Merged

Update hamcrest #241

merged 2 commits into from
Jun 22, 2023

Conversation

NotMyFault
Copy link
Member

🤖 This is an automatic PR for replacing the deprecated 'hamcrest-*' modules with 'hamcrest'.

All deprecated modules' code has been merged into 'hamcrest'.
Consumers of hamcrest-* should replace the dependency with hamcrest, which is the drop-in module containing the code of the deprecated hamcrest-* modules.

Ping @NotMyFault if you have questions.

script source

MarkEWaite
MarkEWaite previously approved these changes Jun 13, 2023
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MarkEWaite MarkEWaite enabled auto-merge (squash) June 13, 2023 14:27
@MarkEWaite
Copy link
Contributor

Seems likely that it will need a test fix on Windows because I expect the same failure in this pull request as is seen in

$ #239

@basil
Copy link
Member

basil commented Jun 13, 2023

Suggest migrating from promote to promote2 in LastBuildPromotionStatusColumnTest and calling .get() on the returned future.

Uses promote2 to request a Future<Promotion> and then retrieve the
promotion with a call to get()
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MarkEWaite MarkEWaite merged commit 345ea92 into jenkinsci:master Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants