Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve the UIX promotions page #271

Merged
merged 2 commits into from
Jan 4, 2024
Merged

Conversation

Spyna
Copy link
Contributor

@Spyna Spyna commented Nov 16, 2023

In the GUI of the promotions page , there is no clear separation between the various promotions, and sometimes you may press the wrong one.

This PR adds a container to the various sections of the page, changing the style as seen in the images below

before

jenkins-promotions-ugly

after

jenkins-promotions

See JENKINS-72461.

Your checklist for this pull request

  • Pull request title represents the changelog entry which will be used in Release Notes. JIRA issue is a part of the title (see existing PRs as examples)
  • Please describe what you did. Short summary for reviewers. If the change involves WebUI, add screenshots
  • Link to relevant Jenkins JIRA issues or pull requests
  • Test automation, if relevant. We expect autotests for all new features or complex bugfixes
  • Documentation if relevant (new features). We want to use Documentation-as-Code, just put docs to README or to new Doc files
  • Javadoc for new APIs. Any public/protected method is considered as API unless annotated by Restricted (docs)

CC

@mention

@Spyna Spyna requested a review from a team as a code owner November 16, 2023 16:04
Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@NotMyFault NotMyFault merged commit 5327e6e into jenkinsci:master Jan 4, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants