[JENKINS-74017] Extract inline script block from BapSshPublisherPlugin/config.jelly

[yaroslavafenkin]

https://issues.jenkins.io/browse/JENKINS-74017

Testing done

Added 2 SSH servers on the Global Configuration page. Went to create a freestyle project. The affected script block is executed upon entering the page. I've checked whether the values and value types stored inside the global variable are the same before and after the change.

Before the change
After the change

Submitter checklist

• Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
• Ensure that the pull request title represents the desired changelog entry
• Please describe what you did
• Link to relevant issues in GitHub or Jira
• Link to relevant pull requests, esp. upstream and downstream changes
• Ensure you have provided tests - that demonstrates feature works or fixes the issue

[yaroslavafenkin]

There doesn't seem to be more correct way to convert string to boolean. We don't expect any values other than "true" or "false", so this should be good enough.
Could alternatively use JSON.parse(effectiveDisableExec) here. Let me know if you like it more and I should change it.

[basil]

Thanks!

[basil]

@gmcdonald Can this please be released? That will get us one step closer to marking this plugin as finished in the CSP compatibility project tracking spreadsheet. If that is not practical, please let me know if I should adopt this plugin. Thanks!

[gmcdonald]

Thanks @basil, I will see about getting it done , will aim for the weekend if that is ok ?

[basil]

Sure, thank you!

[basil]

@gmcdonald Gentle ping that we're still interested in a release. BTW setting up https://www.jenkins.io/doc/developer/publishing/releasing-cd/ would make this less of a personal effort.

[gmcdonald]

Thanks @basil will try and migrate to CD releasing tomorrow. My only concern was about how to interact with the parent publish-over plugin if that affects things at all when it comes time to release a new version of that (and perhaps even a new release of that could auto-bump dependant plugins with its new version number !?)

[basil]

There shouldn't be any negative interactions with dependent plugins when adopting CD. Dependabot is enabled for this repository, so you should get a dependabot PR when the parent plugin is released again.

[gmcdonald]

PRs created for adopting CD -

#363
jenkins-infra/repository-permissions-updater#4181