setting configure_firewall true returns error, port is undefined

[mmarseglia]

Hi,

I enabled the firewall using the following code but received an error.
class { 'jenkins':
configure_firewall => false,
}

include jenkins::master

Error: Failed to apply catalog: Parameter dport failed on Firewall[500 allow Jenkins inbound traffic]: Munging failed for value "undef" in class dport: no such service undef/tcp at /etc/puppetlabs/puppet/modules/jenkins/manifests/firewall.pp:16
Wrapped exception:
Munging failed for value "undef" in class dport: no such service undef/tcp

the firewall module is using $::jenkins::port but I don't see that defined.

[rtyler]

@mmarseglia What version of the module are you using? I just tried this with an RSpec test and couldn't reproduce it :/

[mmarseglia]

the puppetlabs forge version swarm was still at version 1.9 so I git cloned and I have commit 09b8cbc

[rtyler]

@mmarseglia Yeah, I cannot figure out how to reproduce this at all :(

Can you create a sample reproduction case with a small git repo or something like that?

[eshamow]

@rtyler I think it's because strict_variables is set to true in my environment - you can override the value in hiera, but with strict_variables on, if it's not explicitly undefined, compilation fails.

[rtyler]

Noted