Fix for #174 allows setting $jenkins::port #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When used with strict variables turned on, firewall.pp expects $jenkins::port to be set. Overriding in hiera will not correct as it's still an undefined variable in code. This fix allows port to be set and provides a default in params.pp
rtyler
pushed a commit
that referenced
this pull request
Oct 24, 2014
Fix for #174 allows setting $jenkins::port
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When used with strict variables turned on, firewall.pp expects
$jenkins::port to be set. Overriding in hiera will not correct as it's
still an undefined variable in code. This fix allows port to be set and
provides a default in params.pp