[JENKINS-37566] - FindBugs Cleanup. Part #1 #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itializeJarCacheMain#copyFile
Now we use a more agressive check
…o.NioChannelHub$NioTransport.abort
|
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
|
Well, I've definitely broken something. Self-:bug: |
oleg-nenashev
commented
Sep 27, 2016
| ObjectOutputStream oos = new ObjectOutputStream(Mode.TEXT.wrap(os)); | ||
| oos.writeObject(this); | ||
| oos.flush(); | ||
| try (ObjectOutputStream oos = new ObjectOutputStream(Mode.TEXT.wrap(os))) { |
There was a problem hiding this comment.
So it causes the channel close since we also close upstream channels
…ign to be reworked
… RemoteInvocationHandler and UserRequest
|
now it's a timeout |
and some |
stephenc
reviewed
May 2, 2017
| @@ -23,6 +23,7 @@ | |||
| */ | |||
| package hudson.remoting; | |||
|
|
|||
| import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; | |||
| import edu.umd.cs.findbugs.annotations.SuppressWarnings; | |||
There was a problem hiding this comment.
Get rid of the other SuppressWarnings import
stephenc
reviewed
May 2, 2017
| @@ -291,7 +294,7 @@ | |||
| /** | |||
| * Property bag that contains application-specific stuff. | |||
| */ | |||
| private final Hashtable<Object,Object> properties = new Hashtable<Object,Object>(); | |||
| private final ConcurrentHashMap<Object,Object> properties = new ConcurrentHashMap<>(); | |||
There was a problem hiding this comment.
Could this be ConcurrentMap as the declared type?
There was a problem hiding this comment.
It could, will change though there is no much difference since the field is private
stephenc
reviewed
May 2, 2017
| @@ -271,10 +272,10 @@ public ChannelBuilder withProperty(Object key, Object value) { | |||
| } | |||
|
|
|||
| /** | |||
| * @since TODO | |||
| * @since 2.47 | |||
There was a problem hiding this comment.
I would document that the backing map may be subject to concurrent modifications or (better) provide a hint/reminder that the builder is not threadsafe
stephenc
reviewed
May 2, 2017
| @@ -98,7 +103,7 @@ public void write(int c) throws IOException { | |||
| write(new char[]{(char)c},0,1); | |||
| } | |||
|
|
|||
| public void write(char[] cbuf, int off, int len) throws IOException { | |||
| public synchronized void write(char[] cbuf, int off, int len) throws IOException { | |||
There was a problem hiding this comment.
Are we sure this will not introduce risk of deadlock?
There was a problem hiding this comment.
Yes, it makes sense to reimplement it
stephenc
reviewed
May 2, 2017
|
On DV@cloud some tests throw this (suppressed) exception. Not sure why. It is either related to the agent configuration, though it may be a regression after the migration to Java 7 Files API. Works on my machine |
…alidPathException
|
@reviewbybees ready to the review, tests are green with the current CI setup |
stephenc
approved these changes
Nov 8, 2017
oleg-nenashev
commented
Nov 8, 2017
| if (touch) jar.setLastModified(System.currentTimeMillis()); | ||
| if (notified.add(new Checksum(sum1,sum2))) | ||
| if (touch) { | ||
| Files.setLastModifiedTime(jar.toPath(), FileTime.fromMillis(System.currentTimeMillis())); |
There was a problem hiding this comment.
Probably all this code needs to handle InvalidPathException before merging
|
Will fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses 17 issues in the library, mostly related to File operations, concurrency and NITs. 34 issues are still need to be fixed.
@reviewbybees and @stephenc hence some issues come from his code