[JENKINS-39161] - Remoting documentation upgrade for the 3.0 release #121
Conversation
| Major changes: | ||
|
|
||
| * Java 7 is a new target JVM, the new remoting version is not guaranteed to work properly on Java 9 and versions below Java 7 | ||
| * <code>JNLP4-connect</code> and <code>JNLP4-plaintext</code> protocols, which offers a high-performance communication layer |
| * Introduced in: Remoting 3.0, [JENKINS-36871](https://issues.jenkins-ci.org/browse/JENKINS-36871) | ||
| * Use with caution | ||
|
|
||
| The protocol is similar to <code>JNLP4-plaintext</code>, |
| ### JNLP4-plaintext | ||
|
|
||
| * Introduced in: Remoting 3.0, [JENKINS-36871](https://issues.jenkins-ci.org/browse/JENKINS-36871) | ||
| * Use with caution |
There was a problem hiding this comment.
This protocol was developed to allow for like for like performance comparison between the original NIO engine used by JNLP2-connect and the new NIO engine used by JNLP4. As this protocol is plaintext it is not for use outside of like for like performance testing
| but it does not setup the TLS encryption between agent and master. | ||
| In particular cases it may expose the secret data. | ||
|
|
||
| On the other had, the protocol allows to get extra performance in the case when the remoting layer does not need its own encryption |
There was a problem hiding this comment.
Remove this text. The protocol is only to enable like for like performance testing and to allow for focused performance tuning of the stack outside of the performance tuning complexity of SSLEngine that the TLS layer introduces, i.e. By removing the TLS layer we can amplify the effect of IO tuning on system as we have reduced the CPU load
There was a problem hiding this comment.
Yep. I will remove it according to our discussion yesterday
|
@reviewbybees @stephenc Ready for the final review |
|
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
| * `JnlpProtocol` / `JnlpProtocol1` / `JnlpProtocol2` / `JnlpProtocol3` classes were removed. | ||
| Their functionality has been moved to the <code>JnlpProtocolHandler</code> class and its subclasses. | ||
| * <code>JnlpServerHandshake</code> class and all its subclasses have been removed from the library | ||
| * Several debendent internal classes have been removed or modified |
There was a problem hiding this comment.
Dependent is not spelled with a B
|
@reviewbybees @jenkinsci/code-reviewers I'm using my maintainer superpower to merge this PR in order to add links to the Jenkins changelog. This PR does not impact the code && does not go into the release immediately. If you see any other issues in the text, please comment an I will follow-up in other pull requests |
Plan:
@reviewbybees @jenkinsci/code-reviewers
https://issues.jenkins-ci.org/browse/JENKINS-39161