Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-39150] expose diagnostics across all the channels #122

Merged
merged 8 commits into from
Oct 21, 2016

Commits on Oct 20, 2016

  1. [JENKINS-39150] expose diagnostics across all the channels

    To be used by support-core, we need to be able to enumerate all active
    channels. We do this via WeakHashMap so that references get
    automatically garbage collected.
    
    Unclosed channel will remain in memory forever, which also helps us find
    those leaks.
    kohsuke committed Oct 20, 2016
    Configuration menu
    Copy the full SHA
    522a022 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2016

  1. Explaining what these stats mean

    ... and see how they can be interpreted to aid diagnostics
    kohsuke committed Oct 21, 2016
    Configuration menu
    Copy the full SHA
    7c2944a View commit details
    Browse the repository at this point in the history
  2. Linking the ticket

    kohsuke committed Oct 21, 2016
    Configuration menu
    Copy the full SHA
    29df0f3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f27001c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d638fb8 View commit details
    Browse the repository at this point in the history
  5. write to long can be non-atomic without volatile

    JLS (http://docs.oracle.com/javase/specs/jls/se7/html/jls-17.html#jls-17.7) states
    that a write  to non-volatile long variable can go in 32bit batch, so
    without it, read could retrieve a completely bogus value.
    
    There's no risk of writer contention here because that is serialized by
    the context in which it gets invoked.
    kohsuke committed Oct 21, 2016
    Configuration menu
    Copy the full SHA
    9667d4f View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    174168c View commit details
    Browse the repository at this point in the history
  7. Added @SInCE

    kohsuke committed Oct 21, 2016
    Configuration menu
    Copy the full SHA
    07b99b0 View commit details
    Browse the repository at this point in the history