Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle ClosedSelectorException also from Selector.keys #165

Merged
merged 1 commit into from
Jun 16, 2017

Conversation

jglick
Copy link
Member

@jglick jglick commented May 26, 2017

I see this printed at the end of (passing) functional tests, which seems to be pure noise:

… hudson.util.ExceptionCatchingThreadFactory uncaughtException
WARNING: Thread Computer.threadPoolForRemoting [#1] terminated unexpectedly
java.nio.channels.ClosedSelectorException
	at sun.nio.ch.SelectorImpl.keys(SelectorImpl.java:68)
	at org.jenkinsci.remoting.protocol.IOHub.run(IOHub.java:422)
	at jenkins.util.ContextResettingExecutorService$1.run(ContextResettingExecutorService.java:28)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
	at java.lang.Thread.run(Thread.java:748)

We were already handling this exception from various calls in the inner try block—but not from the Selector.keys call used to set Thread.name.

@reviewbybees

@ghost
Copy link

ghost commented May 26, 2017

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@oleg-nenashev oleg-nenashev self-assigned this May 30, 2017
@jglick
Copy link
Member Author

jglick commented May 30, 2017

Linux:

The forked VM terminated without properly saying goodbye. VM crash or System.exit called?

Windows:

Execution version-property of goal org.codehaus.mojo:build-helper-maven-plugin:1.7:regex-property failed: Illegal group reference

@oleg-nenashev
Copy link
Member

#worksonmymachine

Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐝 from what I see. Will manually test before the release

@oleg-nenashev
Copy link
Member

@reviewbybees done

@oleg-nenashev oleg-nenashev merged commit bfb761d into jenkinsci:master Jun 16, 2017
@jglick jglick deleted the ClosedSelectorException branch June 16, 2017 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants