Suppress some irrelevant stack traces #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -383,7 +383,11 @@ public void run() { | |||
| } catch (IOException e) { | |||
| // communication error. | |||
| // this means the caller will block forever | |||
| logger.log(Level.WARNING, "Failed to send back a reply to the request " + this, e); | |||
| if (e instanceof ChannelClosedException) { | |||
| logger.log(Level.INFO, "Failed to send back a reply to the request {0}: {1}", new Object[] {this, e}); | |||
There was a problem hiding this comment.
I would retain the original behavior on the FINE level so that we can locate what caused Closed in some cases.
Or maybe you could retrieve the cause message via new API method or getMessage() update in ChannelStateException
There was a problem hiding this comment.
retrieve the
causemessage
Should not be necessary. Throwable.toString by default prints the toString of a cause.
oleg-nenashev
previously requested changes
Jun 6, 2018
oleg-nenashev
approved these changes
Jun 6, 2018
| int keySize; | ||
| try { | ||
| keySize = selector.keys().size(); | ||
| } catch (ClosedSelectorException x) { |
There was a problem hiding this comment.
See the PR description. There were two exceptions. I fixed both.
saptarshide007
pushed a commit
to saptarshide007/remoting
that referenced
this pull request
Mar 22, 2021
After updating from java 8 to java 11 getting the below error:- Exception in thread "main" java.lang.IllegalArgumentException: object is not an instance of declaring class at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:566) at hudson.remoting.Launcher.addClasspath(Launcher.java:129) On analysing the remoting source code found that the hudson.remoting.Launcher.addClasspath invokes URLClassLoader and passes the instance using ClassLoader.getSystemClassLoader(). However in java 11, this seems like an illegal operation as ClassLoader.getSystemClassLoader() does not get the instance of URLClassLoader due to which we are getting the error "object is not an instance of declaring class". To fix this issue what updated the addClasspath method to invoke the URLClassLoader using a new instance of the class. Reference:- GitIssues:-jenkinsci#274,jenkinsci#275
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed a bunch of stack traces during
io.jenkins.plugins.artifact_manager_jclouds.NetworkTest#unrecoverableExceptionArchiving(jenkinsci/artifact-manager-s3-plugin#41) for example, but really these have been irritating me for a long time (years?):Should now be reduced to:
See also JENKINS-31652, a different case.