Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log the fact that a jar is being sent over channel #767

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

Vlatombe
Copy link
Member

This is already logged through org.jenkinsci.remoting.util.LoggingChannelListener#onJar, however since this logger also logs all packets being read or written, this produces too much noise.

With this change, setting a logger on hudson.remoting.JarLoaderImpl with level FINE will allow to capture all jars being sent over a channel.

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@jglick jglick merged commit 9e0d174 into jenkinsci:master Oct 16, 2024
14 checks passed
@Vlatombe Vlatombe deleted the log-jar-sent-over-channel branch October 17, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants