[JENKINS-22722] - Make AsynchronousCommandTransport tolerant against Socket timeouts #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * interrupted on any {@link SocketTimeoutException}. | ||
| * @since TODO | ||
| */ | ||
| private static boolean RDR_FAIL_ON_SOCKET_TIMEOUT = Boolean.getBoolean(RDR_SOCKET_TIMEOUT_PROPERTY_NAME); |
There was a problem hiding this comment.
Exactly. As I said in the SystemProperties conversation, it was just the first baby step. We will need to move the logic outside Jenkins core into a shared lib
There was a problem hiding this comment.
@KostyaSha deleted his comments
|
🐝 👍 |
|
🐝 |
|
🐝 if you have found some means of testing this at least interactively. Maybe there is some Docker or |
|
@jglick
|
|
👍 |
|
Had a soak testing of the change with 1-second Socket timeout for 48 hours. Integrating the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change prevents failures of the remoting channel on SocketTimeout exceptions if the channel is in the operational state after it. The original behavior can be restored by setting a system property.
It should be a more graceful fix of the issue, which @fengxx was trying to fix in #68
@reviewbybees @KostyaSha @fengxx @jtnord