[JENKINS-35494] - FindBugs - fix minor File Management issues in hudson.remoting.Launcher #88

oleg-nenashev · 2016-06-09T11:33:08Z

Tcp port temporary file is not being closed properly when running in the runAsTcpServer() mode
tcpPortFile deletion issues are not being logged
Resource input stream is not being closed correctly

@reviewbybees

…on.remoting.Launcher - [x] Tcp port temporary file is not being closed properly when running in the runAsTcpServer() mode - [x] tcpPortFile deletion issues are not being logged - [x] Resource input stream is not being closed correctly

stephenc · 2016-06-09T11:53:51Z

🐝 👍

rsandell · 2016-06-09T15:43:21Z

🐝

oleg-nenashev · 2016-06-09T15:47:05Z

@reviewbybees done
I'll merge it as a maintainer

Changes summary: Fixed issues: * [JENKINS-22722](https://issues.jenkins-ci.org/browse/JENKINS-22722) - Make the channel reader tolerant against Socket timeouts. (jenkinsci/remoting#80) * [JENKINS-32326](https://issues.jenkins-ci.org/browse/JENKINS-32326) - Support no_proxy environment variable. (jenkinsci/remoting#84) * [JENKINS-35190](https://issues.jenkins-ci.org/browse/JENKINS-35190) - Do not invoke PingFailureAnalyzer for agent=>master ping failures. (jenkinsci/remoting#85) * [JENKINS-31256](https://issues.jenkins-ci.org/browse/JENKINS-31256) - <code>hudson.Remoting.Engine#waitForServerToBack</code> now uses credentials for connection. (jenkinsci/remoting#87) * [JENKINS-35494](https://issues.jenkins-ci.org/browse/JENKINS-35494) - Fix issues in file management in <code>hudson.remoting.Launcher</code> (main executable class). (jenkinsci/remoting#88) Enhancements: * Ensure a message is logged if remoting fails to override the default <code>ClassFilter</code>. (jenkinsci/remoting#80)

jtnord · 2016-06-13T10:27:37Z

src/main/java/hudson/remoting/Launcher.java

        // accept just one connection and that's it.
        // when we are done, remove the port file to avoid stale port file
        Socket s;
        try {
            s = ss.accept();
            ss.close();
        } finally {
-            tcpPortFile.delete();
+            boolean deleted = tcpPortFile.delete();


BTW - java 7 NIO is much better as it will tell you why it could not delete the file...

oleg-nenashev · 2016-06-13T10:56:39Z

@jtnord Yep, such Java7 improvements make sense. BTW it rather requires a bulk refactoring. I'm not ready to perform it now. Better to fix blocker issues first

Changes summary: Fixed issues: * [JENKINS-22722](https://issues.jenkins-ci.org/browse/JENKINS-22722) - Make the channel reader tolerant against Socket timeouts. (jenkinsci/remoting#80) * [JENKINS-32326](https://issues.jenkins-ci.org/browse/JENKINS-32326) - Support no_proxy environment variable. (jenkinsci/remoting#84) * [JENKINS-35190](https://issues.jenkins-ci.org/browse/JENKINS-35190) - Do not invoke PingFailureAnalyzer for agent=>master ping failures. (jenkinsci/remoting#85) * [JENKINS-31256](https://issues.jenkins-ci.org/browse/JENKINS-31256) - <code>hudson.Remoting.Engine#waitForServerToBack</code> now uses credentials for connection. (jenkinsci/remoting#87) * [JENKINS-35494](https://issues.jenkins-ci.org/browse/JENKINS-35494) - Fix issues in file management in <code>hudson.remoting.Launcher</code> (main executable class). (jenkinsci/remoting#88) Enhancements: * Ensure a message is logged if remoting fails to override the default <code>ClassFilter</code>. (jenkinsci/remoting#80) (cherry picked from commit c718516)

Changes summary: Fixed issues: * [JENKINS-22722](https://issues.jenkins-ci.org/browse/JENKINS-22722) - Make the channel reader tolerant against Socket timeouts. (jenkinsci/remoting#80) * [JENKINS-32326](https://issues.jenkins-ci.org/browse/JENKINS-32326) - Support no_proxy environment variable. (jenkinsci/remoting#84) * [JENKINS-35190](https://issues.jenkins-ci.org/browse/JENKINS-35190) - Do not invoke PingFailureAnalyzer for agent=>master ping failures. (jenkinsci/remoting#85) * [JENKINS-31256](https://issues.jenkins-ci.org/browse/JENKINS-31256) - <code>hudson.Remoting.Engine#waitForServerToBack</code> now uses credentials for connection. (jenkinsci/remoting#87) * [JENKINS-35494](https://issues.jenkins-ci.org/browse/JENKINS-35494) - Fix issues in file management in <code>hudson.remoting.Launcher</code> (main executable class). (jenkinsci/remoting#88) Enhancements: * Ensure a message is logged if remoting fails to override the default <code>ClassFilter</code>. (jenkinsci/remoting#80)

oleg-nenashev merged commit 4610a90 into jenkinsci:master Jun 9, 2016

oleg-nenashev added a commit that referenced this pull request Jun 9, 2016

Noting #88

40abdcc

oleg-nenashev mentioned this pull request Jun 10, 2016

Update remoting to 2.60 jenkinsci/jenkins#2403

Merged

jtnord reviewed Jun 13, 2016
View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[JENKINS-35494] - FindBugs - fix minor File Management issues in hudson.remoting.Launcher #88

[JENKINS-35494] - FindBugs - fix minor File Management issues in hudson.remoting.Launcher #88

oleg-nenashev commented Jun 9, 2016

stephenc commented Jun 9, 2016

rsandell commented Jun 9, 2016

oleg-nenashev commented Jun 9, 2016

jtnord Jun 13, 2016

oleg-nenashev commented Jun 13, 2016

[JENKINS-35494] - FindBugs - fix minor File Management issues in hudson.remoting.Launcher #88

[JENKINS-35494] - FindBugs - fix minor File Management issues in hudson.remoting.Launcher #88

Conversation

oleg-nenashev commented Jun 9, 2016

stephenc commented Jun 9, 2016

rsandell commented Jun 9, 2016

oleg-nenashev commented Jun 9, 2016

jtnord Jun 13, 2016

Choose a reason for hiding this comment

oleg-nenashev commented Jun 13, 2016