FindBugs - Reconsider filters and cleanup some issues #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
| @@ -155,12 +156,6 @@ THE SOFTWARE. | |||
| <optional>true</optional><!-- no need to have this at runtime --> | |||
| </dependency> | |||
| <dependency> | |||
| <groupId>com.github.stephenc.findbugs</groupId> | |||
There was a problem hiding this comment.
@stephenc I think it's no longer required, right? Or is it a licensing issue again?
Ready to go, hehe |
|
CC @olivergondza , who has fixed a couple of issues in his PR |
…EFER_ZERO_LENGTH_ARRAYS)
…UALS_SHOULD_HANDLE_NULL_ARGUMENT)
…MAT_STRING_USES_NEWLINE)
…of wrong inheritance
…JBoss6 (SBSC_USE_STRINGBUFFER_CONCATENATION)
…m another project
…IC_INNER_SHOULD_BE_STATIC)
|
Only 70 issues left... |
…appens only on race condition)
oleg-nenashev
changed the title
| @@ -81,7 +81,7 @@ protected URL retrieve(Channel channel, long sum1, long sum2) throws IOException | |||
| Checksum actual = Checksum.forFile(tmp); | |||
| if (!expected.equals(actual)) { | |||
| throw new IOException(String.format( | |||
| "Incorrect checksum of retrieved jar: %s\nExpected: %s\nActual: %s", | |||
| "Incorrect checksum of retrieved jar: %s%nExpected: %s\nActual: %s", | |||
There was a problem hiding this comment.
The other instance on the same lines.
| @@ -177,9 +180,9 @@ private Channel channel() { | |||
| * @throws IOException if the channel is disconnected or otherwise unavailable. | |||
| * @since FIXME after merge | |||
There was a problem hiding this comment.
Maybe clean up these while you are at it…
There was a problem hiding this comment.
Too many TODOs, gonna to follow-up in a separate PR
|
🐝 |
|
@reviewbybees done |
|
This pull request has completed our internal processes and we now respectfully request the maintainers of this repository to consider our proposal contained within this pull request for merging. |
|
@reviewbybees done |
oleg-nenashev
added a commit
to oleg-nenashev/jenkins
that referenced
this pull request
Aug 14, 2016
Changes are listed below: Fixed issues: * [JENKINS-22853](https://issues.jenkins-ci.org/browse/JENKINS-22853) - Be robust against the delayed EOF command when unexporting input and output streams. (jenkinsci/remoting#97) * Fixed ~20 minor issues reported by FindBugs. More fixes to be delivered in future versions. (jenkinsci/remoting#96) Enhancements: * [JENKINS-37218](https://issues.jenkins-ci.org/browse/JENKINS-37218) - Performance: <code>ClassFilter</code> does not use Regular Expressions anymore to match <code>String.startsWith</code> patterns. (jenkinsci/remoting#92) * [JENKINS-37031](https://issues.jenkins-ci.org/browse/JENKINS-37031) <code>TcpSlaveAgentListener</code> now publishes a list of supported agent protocols to speed up connection setup. (jenkinsci/remoting#93)
DanielWeber
added a commit
to DanielWeber/jenkins
that referenced
this pull request
Aug 26, 2016
(Cherry Pick of 06be933) Changes are listed below: Fixed issues: * [JENKINS-22853](https://issues.jenkins-ci.org/browse/JENKINS-22853) - Be robust against the delayed EOF command when unexporting input and output streams. (jenkinsci/remoting#97) * Fixed ~20 minor issues reported by FindBugs. More fixes to be delivered in future versions. (jenkinsci/remoting#96) Enhancements: * [JENKINS-37218](https://issues.jenkins-ci.org/browse/JENKINS-37218) - Performance: <code>ClassFilter</code> does not use Regular Expressions anymore to match <code>String.startsWith</code> patterns. (jenkinsci/remoting#92) * [JENKINS-37031](https://issues.jenkins-ci.org/browse/JENKINS-37031) <code>TcpSlaveAgentListener</code> now publishes a list of supported agent protocols to speed up connection setup. (jenkinsci/remoting#93)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to restore FindBugs checks in the code. Current filters hide away much real issues, and I would rather admit issues and try to fix it instead of hiding my head in sand.
@reviewbybees