Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tag include and exclude options #28

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MofX
Copy link

@MofX MofX commented Nov 22, 2019

This works the same way as --include and --exclude of the
robot command line utility.
It can be used for example for filtering out skipped tests,
that were marked with a specific tag

Signed-off-by: Joerg Vehlow joerg.vehlow@aox-tech.de

I am willing to add unit tests as well, if this PR gets attention

This works the same way as --include and --exclude of the
robot command line utility.
It can be used for example for filtering out skipped tests,
that were marked with a specific tag

Signed-off-by: Joerg Vehlow <joerg.vehlow@aox-tech.de>
@Tattoo
Copy link
Member

Tattoo commented Nov 23, 2019

Hi,

Thanks for contributing!

Could you illuminate me a bit about what is the intended use case for this feature? Refining the RF log/report that the plugin then publishes is already directly built-in in Robot's rebot tool.

What does this functionality in the plugin add to that?

@MofX
Copy link
Author

MofX commented Nov 23, 2019

As I already described in the commit message, it can be used to exclude skipped tests. If there are different reasons for skipping tests, it could be required for the output.xml to still contain all tests, including skipped ones, for later analysis. That is actually the use case, this pr is designed to solve.

I could imagine, there are also other use cases, like leaving known failing tests or tests drafts out of the statistics while still keeping them in the log for analysis.

@Tattoo
Copy link
Member

Tattoo commented Nov 23, 2019

So it just replicates functionality in Robot Framework itself (as I previously linked)?

@MofX
Copy link
Author

MofX commented Nov 23, 2019

Yes, but it moves the responsibility where it belongs. If the visualized data should be reduced only in jenkins, it should be part of the plugin and not any preprocessing step.

If it was done in preprocessing, the full results are not available anymore (or require another archived file). So there is a big difference between preprocessing and doing it in jenkins

@Tattoo
Copy link
Member

Tattoo commented Nov 23, 2019

I would encourage you to reread what rebot does. It is specifically about post-processing log/report to different versions of log/report with quite extensive possibilities. I do not agree that we should just duplicate this existing functionality as it is code we have to maintain in the future.

I feel this plugin's core tenent is to provide functionality that adds to Robot Framework's.

@MofX
Copy link
Author

MofX commented Nov 23, 2019

I do know, that it can be done using rebot. It is just inconvenient to do it using rebot in some cases.

Imagine a more complicate use case, where jenkins does not do the build itself and maybe even has no access to rebot.

@MofX
Copy link
Author

MofX commented Nov 26, 2019

BTW I am not the first one with this requirement. See https://issues.jenkins-ci.org/browse/JENKINS-8378

@Tanarri
Copy link

Tanarri commented Nov 28, 2019

I appreciate this pr. Would be really helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants