[JENKINS-64955] - Fix execution times in Blue Ocean #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asimell
changed the title
|
LGTM |
|
Would it make sense to cover this by test? |
|
The format is dependent on implementation details of BlueOcean, meaning test would not guard us against it not breaking in the future. If BlueOcean never changes this (which I assume will be the case), the test is wasted effort. If BlueOcean changes this, the test would still always pass because it would not know that the format should be something else. I guess we could build automated acceptance test to check this, but that is a lot of effort considering that this is minor cosmetic issue that is easy to fix. So we decided that this is enough |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use seconds instead of milliseconds in Blue Ocean view.