Add support for Robot Framework 5.0 #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ecd490b.
Tattoo
requested changes
Feb 15, 2022
|
|
||
| @Test | ||
| public void testRobot5Basic() { |
There was a problem hiding this comment.
We will not remember in the future why we test Robot v.5 specifically. I would wish for more descriptive name (eg. testRobot5TryAndWhile) and a comment noting that this was introduced in RF5
There was a problem hiding this comment.
Renamed test and added a comment about test contents.
| @Test | ||
| public void testRobot5Basic() { | ||
| final String dir = "robot5"; | ||
| final String mask = "basic_output.xml"; |
There was a problem hiding this comment.
The same problem as above: we won't remember in the future why we have basic_output.xml for RF5, rather than have a more descriptive name eg. robot5_except_while_output.xml
There was a problem hiding this comment.
Renamed output file.
Tattoo
approved these changes
Mar 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify parser to parse try-catch and while loops.