Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Robot Framework 5.0 #43

Merged
merged 14 commits into from
Mar 25, 2022
Merged

Add support for Robot Framework 5.0 #43

merged 14 commits into from
Mar 25, 2022

Conversation

asimell
Copy link
Contributor

@asimell asimell commented Feb 15, 2022

Modify parser to parse try-catch and while loops.


@Test
public void testRobot5Basic() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will not remember in the future why we test Robot v.5 specifically. I would wish for more descriptive name (eg. testRobot5TryAndWhile) and a comment noting that this was introduced in RF5

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed test and added a comment about test contents.

@Test
public void testRobot5Basic() {
final String dir = "robot5";
final String mask = "basic_output.xml";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same problem as above: we won't remember in the future why we have basic_output.xml for RF5, rather than have a more descriptive name eg. robot5_except_while_output.xml

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed output file.

@asimell asimell marked this pull request as ready for review March 24, 2022 08:03
@asimell asimell requested a review from Tattoo March 25, 2022 07:21
Copy link
Member

@Tattoo Tattoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💖

What version are we releasing? 3.0.2 or 3.1?

@Tattoo Tattoo merged commit 91bc589 into master Mar 25, 2022
@asimell asimell deleted the rf5.0-support branch March 25, 2022 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants