Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt icon path removal from core #46

Merged
merged 1 commit into from
May 23, 2022

Conversation

NotMyFault
Copy link
Member

The change proposed prepares the plugin for the icon path removal from core in the upcoming LTS line. This change affects plugins not using the icon API or relying on paths. Plugins using the API properly in the first place are unaffected by this change.

Could you trigger a release after merging this PR please, giving people a chance to update the plugin before updating to the next LTS version @Tattoo
Thanks in advance!

@Tattoo
Copy link
Member

Tattoo commented Apr 14, 2022

@NotMyFault ,

Could you elaborate more what you mean by:

Plugins using the API properly in the first place are unaffected by this change.

Should we use some API for icons? We'd initially rather fix this problem that way, if it's the proper way

@NotMyFault
Copy link
Member Author

NotMyFault commented Apr 14, 2022

Should we use some API for icons? We'd initially rather fix this problem that way, if it's the proper way

Currently you are relying on the path of the icon, which is going to be removed in the next LTS version.
The change I proposed moves you to using the proper API, which is unaffected by this change and will display the icon without relying on a static path.

@NotMyFault
Copy link
Member Author

@Tattoo Is there anything that blocks this PR?

@Tattoo
Copy link
Member

Tattoo commented May 20, 2022

@NotMyFault ,

nothing blocking the PR except being busy, sorry for that 😅

we are aiming to do a new release in the coming weeks, this PR is planned to be part of it

@asimell asimell merged commit 0f765d7 into jenkinsci:master May 23, 2022
@NotMyFault NotMyFault deleted the fix/master/adapt-icon-removal branch May 23, 2022 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants