Suite might not have name at all #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In RF4, suite name in output.xml might be non-existent in some cases (see more
below [*]). In these cases, `RobotTestObject.getName()` returned null as well,
which became problem for `RobotTestObject.getRelativePackageName()`.
Handle null from `getName()` as an empty string.
[*] RF uses double underscore ('__') in suite name as a separator as per
https://robotframework.org/robotframework/latest/RobotFrameworkUserGuide.html#test-suite-name-and-documentation
If user has named their suite so it ends with double undercore (eg.
suite__.robot), suite name is of course empty. Before RF5, this meant
output.xml's <suite> tag did not get name-attribute at all; hence the null.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes JENKINS-69807
In RF4, suite name in output.xml might be non-existent in some cases (see more below [*]). In these cases,
RobotTestObject.getName()returned null as well, which became problem forRobotTestObject.getRelativePackageName().Handle null from
getName()as an empty string.[*] RF uses double underscore ('__') in suite name as a separator as per https://robotframework.org/robotframework/latest/RobotFrameworkUserGuide.html#test-suite-name-and-documentation
If user has named their suite so it ends with double undercore (eg. suite__.robot), suite name is of course empty. Before RF5, this meant output.xml's tag did not get name-attribute at all; hence the null.