Minor enhancements #314

mawinter69 · 2023-07-08T22:38:29Z

Some minor enhancements

fixed a typo
table highlighting works on the cell and not the input to avoid flickering when moving around the mouse
highlight row when on the delete button on the right

Internal changes

use template element instead of a hidden row that gets removed
use let instead of varin js files where applicable

Testing done

Submitter checklist

Give feedback

Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
Ensure that the pull request title represents the desired changelog entry
Please describe what you did
Link to relevant issues in GitHub or Jira
Link to relevant pull requests, esp. upstream and downstream changes
Ensure you have provided tests - that demonstrates feature works or fixes the issue
Options

the hover effect was only on the input. That lead to the highlight be turned leaving the input end turn it on again in the next cell of the table. The mouseover is now on the td which avoids the flickering. move the templates to a template element out of the table.

mawinter69 added 4 commits July 8, 2023 19:19

fix typo

7f2f713

highlight row when hovering over last delete button

c30d4b0

reduce variable scope

dc66e8d

mawinter69 added the enhancement label Jul 8, 2023

mawinter69 requested a review from a team as a code owner July 8, 2023 22:38

mawinter69 added the internal label Jul 8, 2023

mawinter69 merged commit 4d4f871 into jenkinsci:master Jul 8, 2023

mawinter69 deleted the minor-enhancements branch July 13, 2023 20:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Minor enhancements #314

Minor enhancements #314

mawinter69 commented Jul 8, 2023 •

edited

Loading

Submitter checklist

Minor enhancements #314

Minor enhancements #314

Conversation

mawinter69 commented Jul 8, 2023 • edited Loading

Testing done

Submitter checklist

mawinter69 commented Jul 8, 2023 •

edited

Loading