Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test with Java 21 and Java 17 #277

Merged
merged 7 commits into from
Jul 19, 2024

Conversation

MarkEWaite
Copy link

Test with Java 21 and Java 17

Java 21 released Sep 19, 2023. Full support for Java 21 in Jenkins was announced in November 2023.

The acceptance test harness and plugin bill of materials tests are already passing with Java 21. This is a further step to improve plugin readiness for use with Java 21 and for development with Java 21. Prepares for the Oct 2024 end of life of Java 11.

This does not test Java 11 because the Java 17 build and the Java 21 build are both generating Java 11 byte code. We've detected no issues related to building Java 11 byte code with Java 17 and Java 21.

This is one of the last plugins in the top 250 most popular plugins to not yet test with Java 17 and Java 21.

Includes or supersedes the following pull requests:

Testing done

Confirmed that tests pass with Java 21 on Red Hat Enterprise Linux 8 and Ubuntu 22.04. Confirmed that tests pass with Java 17 on Red Hat Enterprise Linux 8.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

dependabot bot and others added 7 commits October 30, 2023 14:18
Bumps [io.jenkins.tools.bom:bom-2.387.x](https://github.com/jenkinsci/bom) from 2446.v2e9fd3b_d8c81 to 2543.vfb_1a_5fb_9496d.
- [Release notes](https://github.com/jenkinsci/bom/releases)
- [Commits](https://github.com/jenkinsci/bom/commits)

---
updated-dependencies:
- dependency-name: io.jenkins.tools.bom:bom-2.387.x
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [org.testcontainers:testcontainers](https://github.com/testcontainers/testcontainers-java) from 1.19.0 to 1.19.3.
- [Release notes](https://github.com/testcontainers/testcontainers-java/releases)
- [Changelog](https://github.com/testcontainers/testcontainers-java/blob/main/CHANGELOG.md)
- [Commits](testcontainers/testcontainers-java@1.19.0...1.19.3)

---
updated-dependencies:
- dependency-name: org.testcontainers:testcontainers
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [org.jenkins-ci.plugins:plugin](https://github.com/jenkinsci/plugin-pom) from 4.73 to 4.76.
- [Release notes](https://github.com/jenkinsci/plugin-pom/releases)
- [Changelog](https://github.com/jenkinsci/plugin-pom/blob/master/CHANGELOG.md)
- [Commits](jenkinsci/plugin-pom@plugin-4.73...plugin-4.76)

---
updated-dependencies:
- dependency-name: org.jenkins-ci.plugins:plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Java 21 released Sep 19, 2023. Full support for Java 21 was announced
in November 2023.

The acceptance test harness and plugin bill of materials tests are already
passing with Java 21. This is a further step to improve plugin readiness
for use with Java 21 and for development with Java 21.

This does not test Java 11 because the Java 17 build and the Java 21
build are both generating Java 11 byte code.  We've detected no issues
related to building Java 11 byte code with Java 17 and Java 21.
… 'dependabot/maven/io.jenkins.tools.bom-bom-2.387.x-2543.vfb_1a_5fb_9496d' and 'dependabot/maven/org.testcontainers-testcontainers-1.19.3' into test-with-java-21
@@ -99,7 +99,7 @@
<dependency>
<groupId>org.testcontainers</groupId>
<artifactId>testcontainers</artifactId>
<version>1.19.0</version>
<version>1.19.3</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine but not related to this pull request

@@ -119,7 +119,7 @@
<dependency>
<groupId>io.jenkins.tools.bom</groupId>
<artifactId>bom-2.387.x</artifactId>
<version>2446.v2e9fd3b_d8c81</version>
<version>2543.vfb_1a_5fb_9496d</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine but not related to this pull request

@alecharp alecharp added this pull request to the merge queue Jul 19, 2024
Merged via the queue into jenkinsci:master with commit cbdb3dc Jul 19, 2024
14 checks passed
@MarkEWaite MarkEWaite deleted the test-with-java-21 branch July 19, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants