-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using own executor service #61
Changes from 5 commits
f5b5887
aa36937
7c7b6e1
066f398
713c127
38c2c5a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -34,12 +34,17 @@ | |
import hudson.security.ACL; | ||
import java.util.Date; | ||
import java.util.concurrent.ScheduledExecutorService; | ||
import java.util.concurrent.ScheduledThreadPoolExecutor; | ||
import java.util.concurrent.atomic.AtomicLong; | ||
import java.util.concurrent.locks.Condition; | ||
import java.util.concurrent.locks.Lock; | ||
import java.util.concurrent.locks.ReentrantLock; | ||
import javax.servlet.http.HttpServletRequest; | ||
import jenkins.util.Timer; | ||
|
||
import hudson.util.ClassLoaderSanityThreadFactory; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. all imports in a-z order, no blank lines please |
||
import hudson.util.DaemonThreadFactory; | ||
import hudson.util.NamingThreadFactory; | ||
import jenkins.security.ImpersonatingScheduledExecutorService; | ||
import org.acegisecurity.context.SecurityContext; | ||
import org.acegisecurity.context.SecurityContextHolder; | ||
import org.apache.commons.lang.StringUtils; | ||
|
@@ -126,6 +131,11 @@ public abstract class SCMEvent<P> { | |
@CheckForNull | ||
private final String origin; | ||
|
||
/** | ||
* The scheduled executor thread pool. This is initialized lazily since it may be never needed. | ||
*/ | ||
private static ScheduledExecutorService executorService; | ||
|
||
/** | ||
* Constructor to use when the timestamp is available from the external SCM. | ||
* | ||
|
@@ -198,10 +208,13 @@ protected SCMEvent(SCMEvent<P> copy) { | |
* @return a {@link ScheduledExecutorService}. | ||
*/ | ||
@NonNull | ||
protected static ScheduledExecutorService executorService() { | ||
// Future-proofing, if we find out that events are drowning Timer then we may need to move them to their | ||
// own dedicated ScheduledExecutorService thread pool | ||
return Timer.get(); | ||
protected static synchronized ScheduledExecutorService executorService() { | ||
if (executorService == null) { | ||
// corePoolSize is set to 10, but will only be created if needed. | ||
// ScheduledThreadPoolExecutor "acts as a fixed-sized pool using corePoolSize threads" | ||
executorService = new ImpersonatingScheduledExecutorService(new ScheduledThreadPoolExecutor(10, new NamingThreadFactory(new ClassLoaderSanityThreadFactory(new DaemonThreadFactory()), "SCMEvent")), ACL.SYSTEM); | ||
} | ||
return executorService; | ||
} | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we'll need a |
||
/** | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW usually preferable to update to the oldest LTS line that has whatever core API you need. Especially in this case, because the plugin is an API intended to be used by other plugins, requiring the second-newest LTS release means that any plugin that wants to pick up the latest version of this plugin (for example jenkinsci/workflow-cps-global-lib-plugin#68) also requires that release, which is a bit prohibitive.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case
2.107.3
was the minimum required baseline as far as I know.