[JENKINS-74741] Migrate from FromApply#applyResponse in ScriptlerBuilder.java

[yaroslavafenkin]

https://issues.jenkins.io/browse/JENKINS-74741

FormApply#applyResponse is deprecated in favor of CSP compatible FormApply#showNotification available since version 2.482 of Jenkins.

Testing done

Before the change
After the change

Submitter checklist

• Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
• Ensure that the pull request title represents the desired changelog entry
• Please describe what you did
• Link to relevant issues in GitHub or Jira
• Link to relevant pull requests, esp. upstream and downstream changes
• Ensure you have provided tests - that demonstrates feature works or fixes the issue

[mtughan]

Thanks @yaroslavafenkin. I won't be merging this quite yet as I'm working on a large update to the internals of the plugin to make it compatible with Jenkins 2.479+ and Java 17, but I will bring this in shortly after.

One other question: this PR is currently marked as a draft. Is that intentional?

[yaroslavafenkin]

Thanks @yaroslavafenkin. I won't be merging this quite yet as I'm working on a large update to the internals of the plugin to make it compatible with Jenkins 2.479+ and Java 17, but I will bring this in shortly after.

One other question: this PR is currently marked as a draft. Is that intentional?

Hi.
Yes, PR is intentionally marked as a draft for now. When it comes to the CSP code it seems fine. I'm not sure if I handled the bump of the core version correctly (along with the Jakarta thing) as unit tests are failing. For that reason I'm not marking this as ready.
I think this can wait for your large update. I can make the adjustments to this PR after you're done.

[basil]

I'm not sure if I handled the bump of the core version correctly (along with the Jakarta thing) as unit tests are failing. For that reason I'm not marking this as ready.

Fixed in commit a1b0467

[basil]

I won't be merging this quite yet as I'm working on a large update to the internals of the plugin to make it compatible with Jenkins 2.479+ and Java 17, but I will bring this in shortly after.

This PR has a fully passing CI build, so is there any reason to merge this PR after the update you are working on rather than before? True, this PR updates the baseline to a weekly release, which is rare (in this case, a CSP method has not been backported to LTS yet), but if there is a desire to deliver any updates to users of LTS lines, a backport branch can be created as in https://gist.github.com/jglick/86a30894446ed38f918050c1180483e2.

[mtughan]

@yaroslavafenkin, anything else stand out to you or is this good to merge?

[yaroslavafenkin]

@yaroslavafenkin, anything else stand out to you or is this good to merge?

LGTM

[mtughan]

Thanks for contributing this!