Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Jenkins proxy configuration support #28

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

moritzrupp
Copy link

@moritzrupp moritzrupp commented Jan 27, 2022

To support larger corporations, the support for proxies is added.
The generic proxy configuration of Jenkins is used to communicate via proxy with the ServiceNow instance.

Referecne: #27

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@chiarnglin

To support larger corporations, the support for proxies is added.
The generic proxy configuration of Jenkins is used to communicate
via proxy with the ServiceNow instance.

Referecne: jenkinsci#27
@moritzrupp moritzrupp mentioned this pull request Mar 2, 2022
@tdprot
Copy link

tdprot commented Apr 20, 2023

@chiarng @kamilgo @basil
Is there any reason that this pull request, which would be essential for enterprise environments, is not merged?

@basil
Copy link
Member

basil commented Apr 20, 2023

I am just a Jenkins core maintainer, not a maintainer of this plugin: I only adopted this plugin temporarily to ship some changes adapting to a recent Jenkins core release, and I don't use ServiceNow. Since this plugin appears to be maintained by a corporate team at ServiceNow, I don't want to interfere with feature requests like this, so I will leave it up to them, but I can confirm this is a valid use case, and the implementation looks correct to me. See also jenkinsci/jenkins#7398 which attempts to introduce a high-level API for this use case in more recent versions of Jenkins core. (The testing notes in that PR might be interesting.) Assuming this PR has been properly tested, I would highly recommend the ServiceNow developers team merge and release this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants