Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate tests to JUnit5 #1029

Merged
merged 2 commits into from
Jan 27, 2025
Merged

Conversation

strangelookingnerd
Copy link
Contributor

@strangelookingnerd strangelookingnerd commented Jan 24, 2025

This PR aims to migrate all tests to JUnit5. Changes include:

  • Migrate annotations and imports
  • Migrate assertions
  • Migrate MockitoAnnotations.initMocks to Extension
  • Remove public visibility for test classes and methods
  • Minor clean up

I am well aware that this is a quite large changeset however I hope that there is still interest in this PR and it will be reviewed.
If there are any questions, please do not hesitate to ping me.

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side) and not your master branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

* Migrate annotations and imports
* Migrate assertions
* Migrate MockitoAnnotations.initMocks to Extension
* Remove public visibility for test classes and methods
* Minor clean up
@strangelookingnerd strangelookingnerd marked this pull request as ready for review January 27, 2025 19:33
@strangelookingnerd strangelookingnerd requested a review from a team as a code owner January 27, 2025 19:33
@timja timja added chore test and removed chore labels Jan 27, 2025
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks LGTM!

@timja timja merged commit ec04842 into jenkinsci:master Jan 27, 2025
17 checks passed
@strangelookingnerd strangelookingnerd deleted the migrate_to_junit5 branch January 27, 2025 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants