Allow users who have permission on job configuration to set credential id #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l id Currently, only administrators can set credential id to Slack integration token. Credential id should be able to set by non-administrator users if they have permission on job configuration.
eagletmt
force-pushed
the
allow-non-admins
branch
from
4e1d59d to
32335db
Compare
|
Looking for some additional code reviewers (other than me). I can review and test this but would like a second set of eyes that's not me nor @eagletmt. Thanks for your contribution; in lieu of reviews I'll make a decision one way or another after an arbitrary period of time. |
|
Any progress on this? |
@samrocketman Seems like quite a long time has passed since that comment. Any chance of merging this? |
|
Any news on this PR ? Looks like no one is maintaining this plugin anymore... |
|
see #372 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, only administrators can set credential id to Slack
integration token. Credential id should be able to set by
non-administrator users if they have permission on job configuration.
This patch should fix #272 .