Send more advanced slack messages v2 #324

gurumaia · 2017-06-02T16:34:31Z

Based on @ahmetrehaseker's implementation.
This is a change to support slack complex messaging.
See #285 for more details.

if attachments doesnot contain fallback set message as fallback JSONArray converted to String ReadMe modified ReadMe modified test fix

Improved readme

rafi-tvtime

looks good to me. let's do this!

gurumaia · 2017-06-08T15:02:34Z

Can someone review this?

samrocketman · 2017-06-15T05:13:35Z

Hey @gurumaia, I'll take a look as well and try bootstrapping it with https://github.com/samrocketman/jenkins-bootstrap-slack. Please also refer to #320 as I generally am attempting to distance myself from this plugin specifically.

ejohansson

Looks good, no apparent issues.

ejohansson

Doc looks good to me, test looks good.

gurumaia · 2017-06-20T15:25:05Z

Alright, great @samrocketman. I did see your commits about removing yourself as a maintainer. I can try to step up and help maintain the plugin if you'd like.

samrocketman · 2017-06-25T23:28:09Z

@gurumaia you're welcome to step up and maintain. Feel free to check in with @kmadel who, as far as I know, has not relinquished being the other maintainer. I'm sure he wouldn't mind bringing you on board. Feel free to send a message to the developers mailing list, mention Kurt, and this discussion.

djk · 2017-07-05T09:34:10Z

Would be amazing to have this reviewed and hopefully approved. Is @gurumaia taking it over?

gurumaia · 2017-07-05T10:25:07Z

Hey @djk I'll contact @kmadel to see if I can get in. This has been on the back of my mind lately as I've had quite a few rushed days these past few weeks.
Btw, the plugin has been working nicely in my production environment. While this isn't approved, feel free to clone my repo and build using the instructions in the readme.

djk · 2017-07-05T10:49:44Z

Thanks @gurumaia, I'll check your repo!

Wasn't hassling you, hope it doesn't feel that way. Thanks for the great work.

gurumaia · 2017-07-05T10:52:24Z

Absolutely no hassling =).

btw, I didn't actually code this, I just took @ahmetrehaseker's old PR and performed @samrocketman's suggestions.

djk · 2017-07-07T06:36:52Z

@gurumaia

Ah right, well thanks to @ahmetrehaseker and @samrocketman too!

~~One thing, not sure where best to mention this but does your PR support "fields": https://api.slack.com/docs/message-attachments#fields~~

~~I'm not quite sure how one would enter a JSON array into the example that you provided on the page of your fork.~~

EDIT: Got it to work with help of a friend, like:

      JSONObject fieldOne = new JSONObject();
        fieldOne.put('title', 'Build');
        fieldOne.put('value', "<${env.BUILD_URL}|${env.BUILD_NUMBER}>");
        fieldOne.put('short', true);
        fields.add(fieldOne);

And repeating for more fields etc.

EDIT: The above doesn't seem to work in regard to actually doing the interpolation of variables. Is there some escaping required?

Thanks again!

gurumaia · 2017-07-13T17:38:42Z

@djk sorry, I missed your edit.
The code you posted seems like it should work fine. What value are you getting in slack?
For reference, here's an example from one of my internal projects:

        String artifactUrl = "${env.NEXUS_URL_NOTIFY}${env.pom_groupId}/${env.pom_artifactId}/${env.pom_new_version}/${env.pom_artifactId}-${env.pom_new_version}.${env.pom_packaging}"

        JSONArray fields = new JSONArray();
        JSONObject field = new JSONObject();
        field.put('title','URL Nexus');
        field.put('value',artifactUrl);
        fields.add(field);
        attachment.put('fields',fields);

@kmadel If you could review this PR, I can go ahead and merge it.
Thanks

kmadel · 2017-07-20T19:12:31Z

Decent doc update, it has tests, looks ok to me. I so go for it @gurumaia and thanks.

DaBs

Looks good, has tests, new features are much needed in a lot of cases.

rafi-tvtime · 2017-08-08T17:58:14Z

Is this being merged?

brianespinosa · 2017-08-10T20:06:37Z

+1 for this feature getting merged now that it appears to have tests and looks good.

gurumaia · 2017-08-15T00:04:06Z

I've merged and now I'm waiting for approval on my request for upload access to actually release it: jenkins-infra/repository-permissions-updater#399

brianespinosa · 2017-08-30T19:52:27Z

@gurumaia Any idea on timing to release this? I noticed that your above referenced PR giving you access has been merged. Thanks again for your help taking this over.

gurumaia · 2017-09-01T10:29:06Z

Hey @brianespinosa I've finally released it to the update center yesterday. Should be available now. Please test it and let me know if it works well for you.

ghost · 2017-10-06T16:12:42Z

Doesn't this revert the fix in 3905e00#diff-282db0eb13a24d1729df3e194a35f6d7 #274 made by @p00j4 ?
So that messages over 4K will be truncated again. Because that is at least what I am seeing in version 2.3.

ahmetrehaseker and others added 2 commits June 2, 2017 11:29

Slack send message with attachments

a968581

if attachments doesnot contain fallback set message as fallback JSONArray converted to String ReadMe modified ReadMe modified test fix

Fixed getSlackService test

d12eb00

Improved readme

gurumaia mentioned this pull request Jun 2, 2017

Send more advanced slack messages #285

Closed

rafi-tvtime reviewed Jun 2, 2017

View reviewed changes

ejohansson approved these changes Jun 20, 2017

View reviewed changes

Added Gustavo Maia as a maintainer

866d205

DaBs approved these changes Aug 1, 2017

View reviewed changes

samrocketman mentioned this pull request Aug 14, 2017

Outdated README and Failure all the time (2.2 version) #312

Closed

gurumaia merged commit 0757425 into jenkinsci:master Aug 14, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Send more advanced slack messages v2 #324

Send more advanced slack messages v2 #324

gurumaia commented Jun 2, 2017

rafi-tvtime left a comment

gurumaia commented Jun 8, 2017

samrocketman commented Jun 15, 2017 •

edited

Loading

ejohansson left a comment

ejohansson left a comment

gurumaia commented Jun 20, 2017

samrocketman commented Jun 25, 2017

djk commented Jul 5, 2017

gurumaia commented Jul 5, 2017

djk commented Jul 5, 2017

gurumaia commented Jul 5, 2017

djk commented Jul 7, 2017 •

edited

Loading

gurumaia commented Jul 13, 2017

kmadel commented Jul 20, 2017

DaBs left a comment •

edited

Loading

rafi-tvtime commented Aug 8, 2017

brianespinosa commented Aug 10, 2017

gurumaia commented Aug 15, 2017

brianespinosa commented Aug 30, 2017

gurumaia commented Sep 1, 2017

ghost commented Oct 6, 2017

Send more advanced slack messages v2 #324

Send more advanced slack messages v2 #324

Conversation

gurumaia commented Jun 2, 2017

rafi-tvtime left a comment

Choose a reason for hiding this comment

gurumaia commented Jun 8, 2017

samrocketman commented Jun 15, 2017 • edited Loading

ejohansson left a comment

Choose a reason for hiding this comment

ejohansson left a comment

Choose a reason for hiding this comment

gurumaia commented Jun 20, 2017

samrocketman commented Jun 25, 2017

djk commented Jul 5, 2017

gurumaia commented Jul 5, 2017

djk commented Jul 5, 2017

gurumaia commented Jul 5, 2017

djk commented Jul 7, 2017 • edited Loading

gurumaia commented Jul 13, 2017

kmadel commented Jul 20, 2017

DaBs left a comment • edited Loading

Choose a reason for hiding this comment

rafi-tvtime commented Aug 8, 2017

brianespinosa commented Aug 10, 2017

gurumaia commented Aug 15, 2017

brianespinosa commented Aug 30, 2017

gurumaia commented Sep 1, 2017

ghost commented Oct 6, 2017

samrocketman commented Jun 15, 2017 •

edited

Loading

djk commented Jul 7, 2017 •

edited

Loading

DaBs left a comment •

edited

Loading