Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Don't publish twice, while the build isn't finished yet (#446)" #457

Merged
merged 2 commits into from
Dec 20, 2018

Conversation

timja
Copy link
Member

@timja timja commented Dec 20, 2018

This reverts commit e66caf6.

Closes #455

@timja
Copy link
Member Author

timja commented Dec 20, 2018

@KreAch3R seems like r.isBuilding was returning true when free style jobs were running the complete build bit

@timja timja merged commit bef1611 into jenkinsci:master Dec 20, 2018
@timja timja deleted the feature/revert-446-publish-twice branch December 20, 2018 16:23
@KreAch3R
Copy link
Contributor

What kind of job do you use @dshvedchenko ?

Yeah we should revert this for now since it produces regressions but it will still throw 3 messages, I'll go back to the drawing board. That's why I need a setup where the notifications are failing

@dshvedchenko
Copy link

Yep. we use FreeStyle job. and Success is result of Build Step. but job is continue in Publish pahse

@KreAch3R
Copy link
Contributor

What do you mean? Can you try creating a new basic freestyle job like the one I describe here: #446 (comment) and check if you get three notifications, like these:

test - #41 Started by user admin (Open)
test - #41 Success after 4.1 sec and counting (Open)
test - #41 Success after 4.9 sec (Open)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants