Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a default implementation of SSHUserPrivateKey#getPrivateKey #197

Conversation

Vlatombe
Copy link
Member

@Vlatombe Vlatombe commented Mar 1, 2024

This method is deprecated, and implementation still need to implement it. We have default methods now, so let's just leverage that to avoid useless boilerplate.

Testing done

Submitter checklist

This method is deprecated, and implementation still need to implement it. We have default methods now, so let's just leverage that to avoid useless boilerplate.
@Vlatombe
Copy link
Member Author

Vlatombe commented Mar 4, 2024

Gentle ping to @jtnord or @olamy since you last merged PRs in this repository.

Copy link
Member

@jtnord jtnord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

given it was deprecated 11 years ago would it not behove us to remove it instead?

@Vlatombe
Copy link
Member Author

Vlatombe commented Mar 4, 2024

@jtnord Feel free to do so, but considering the number of existing impls, I didn't want to bother breaking them.

@jtnord jtnord merged commit e57bb1f into jenkinsci:master Mar 4, 2024
15 checks passed
@Vlatombe Vlatombe deleted the do-not-require-implementation-of-deprecated-method branch March 4, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants