Use plugin bom version prior to trilead API upgrade #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The plugin compatibility tester mistakenly uses the version of optional plugins that is provided by the pom of the tested plugin rather than using the version of plugin that is listed in the pom file of the plugin bill of materials. Because of that issue, the 2.426.x plugin bill of materials version needs to remain on an older version in order to not include an optional dependency on a newer version of the trilead API plugin. 3080.vfa_b_e4a_a_39b_44 is the version immediately before a trilean API plugin upgrade in the BOM. jenkinsci/bom#3404 has more details jenkinsci#211 includes some discussion as well.
olamy
reviewed
Jul 25, 2024
| @@ -93,7 +93,11 @@ | |||
| <dependency> | |||
| <groupId>io.jenkins.tools.bom</groupId> | |||
| <artifactId>bom-2.426.x</artifactId> | |||
| <version>3208.vb_21177d4b_cd9</version> | |||
| <!-- Last 2.426.x BOM version before a trilead api upgrade --> | |||
| <!-- Trilead API upgrade breaks plugin compatibility tests due to poor handling of optional dependencies --> | |||
There was a problem hiding this comment.
Do we have an issue recorded somewhere related to this problem?
There was a problem hiding this comment.
MarkEWaite
added a commit
to MarkEWaite/bom
that referenced
this pull request
Jul 25, 2024
jenkinsci/ssh-credentials-plugin#212 is the pull request that provided the incremental version.
6 tasks
|
Passed a full test of the plugin bom. Ready to merge and release. |
|
@olamy could you label the pull request as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use plugin bom version prior to trilead API upgrade
The plugin compatibility tester mistakenly uses the version of optional plugins that is provided by the pom of the tested plugin rather than using the version of plugin that is listed in the pom file of the plugin bill of materials.
Because of that issue, the 2.426.x plugin bill of materials version needs to remain on an older version in order to not include an optional dependency on a newer version of the trilead API plugin.
3080.vfa_b_e4a_a_39b_44 is the version immediately before a trilead API plugin upgrade in the BOM.
More details are available in:
Additional information is also available in:
Testing done
Confirmed that plugin BOM tests pass with:
LINE=2.440.x PLUGINS=git-server,workflow-basic-steps,git,pipeline-model-definition,docker-workflow,blueocean TEST=InjectedTest bash local-test.shOnce an incremental build is available for this pull request, I'll test it with the plugin BOM.
Submitter checklist