Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JENKINS-52225 Upgrade to latest JSch Version #2

Merged
merged 2 commits into from
Jul 3, 2018
Merged

Conversation

nrayapati
Copy link
Member

Description

  • Upgraded to latest JSch Version
  • Update all DisplayNames to include the step name
  • Add log message to sshScriptStep to print the file name.

See JENKINS-52225.

- Update all DisplayNames to include the step name
- Add log message to sshScriptStep to print the file name.
@nrayapati nrayapati requested review from ghenkes and wwftw July 3, 2018 18:28
@nrayapati
Copy link
Member Author

Have tested this locally and changes looks good. Thank you.

@@ -49,7 +49,7 @@ public String getFunctionName() {

@Override
public String getDisplayName() {
return getPrefix() + "Execute command on remote node.";
return getPrefix() + "sshCommand - Execute command on remote node.";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this use getFunctionName?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Updated with a89f5da

@nrayapati
Copy link
Member Author

Thank you @ghenkes

@nrayapati nrayapati self-assigned this Jul 3, 2018
@nrayapati nrayapati added the enhancement New feature or request label Jul 3, 2018
@nrayapati
Copy link
Member Author

Thank you @wuchenwang 👍

@nrayapati nrayapati merged commit aedee57 into master Jul 3, 2018
@nrayapati nrayapati deleted the JENKINS-52225 branch July 3, 2018 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants