Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump bom-2.346.x from 1706.vc166d5f429f8 to 1723.vcb_9fee52c9fc #107

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 28, 2022

Bumps bom-2.346.x from 1706.vc166d5f429f8 to 1723.vcb_9fee52c9fc.

Release notes

Sourced from bom-2.346.x's releases.

1723.vcb_9fee52c9fc

🐛 Bug fixes

📦 Dependency updates

1722.v58c68a_b_b_2559

👷 Changes for plugin developers

👻 Maintenance

📦 Dependency updates

  • Bump junit from 1160.vf1f01a_a_ea_b_7f to 1166.va_436e268e972 in /bom-weekly (#1605) @​dependabot
  • Bump pipeline-input-step from 456.vd8a_957db_5b_e9 to 466.v6d0a_5df34f81 in /bom-weekly (#1604) @​dependabot
  • Bump git-plugin.version from 4.13.0 to 4.14.0 in /bom-weekly (#1603) @​dependabot
  • Bump lockable-resources from 2.18 to 1069.v726298f53f8c in /bom-weekly (#1600) @​dependabot
  • Bump plugin from 4.50 to 4.51 in /sample-plugin (#1598) @​dependabot
  • Bump jnr-posix-api from 3.1.15-2 to 3.1.16-1 in /bom-weekly (#1599) @​dependabot
  • Bump trilead-api from 2.72.v2a_3236754f73 to 2.84.v72119de229b_7 in /bom-weekly (#1597) @​dependabot
  • Bump pipeline-utility-steps from 2.13.2 to 2.14.0 in /bom-weekly (#1595) @​dependabot
  • Bump mina-sshd-api.version from 2.9.1-44.v476733c11f82 to 2.9.2-50.va_0e1f42659a_a in /bom-weekly (#1591) @​dependabot
  • Bump token-macro from 308.v4f2b_ed62b_b_16 to 321.vd7cc1f2a_52c8 in /bom-weekly (#1592) @​dependabot
  • Bump workflow-durable-task-step from 1210.va_1e5d77e122b to 1217.v38306d8fa_b_5c in /bom-weekly (#1588) @​dependabot
  • Bump workflow-cps-global-lib from 588.v576c103a_ff86 to 609.vd95673f149b_b in /bom-weekly (#1589) @​dependabot
  • Bump pipeline-groovy-lib from 613.v9c41a_160233f to 621.vb_44ce045b_582 in /bom-weekly (#1590) @​dependabot
  • Bump script-security from 1190.v65867a_a_47126 to 1218.v39ca_7f7ed0a_c in /bom-weekly (#1587) @​dependabot
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @NotMyFault.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [bom-2.346.x](https://github.com/jenkinsci/bom) from 1706.vc166d5f429f8 to 1723.vcb_9fee52c9fc.
- [Release notes](https://github.com/jenkinsci/bom/releases)
- [Commits](https://github.com/jenkinsci/bom/commits)

---
updated-dependencies:
- dependency-name: io.jenkins.tools.bom:bom-2.346.x
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Nov 28, 2022
Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dependabot squash and merge

@dependabot dependabot bot merged commit bae71e6 into main Nov 28, 2022
@dependabot dependabot bot deleted the dependabot/maven/io.jenkins.tools.bom-bom-2.346.x-1723.vcb_9fee52c9fc branch November 28, 2022 11:21
@famod
Copy link

famod commented Nov 29, 2022

@NotMyFault AFAICS, this will fix https://access.redhat.com/security/cve/CVE-2022-45047 (TBH, I haven't checked whether sshd-plugin is actually vulnerable).
Are you going to cut a release anytime soon? Thanks!

@NotMyFault
Copy link
Member

(TBH, I haven't checked whether sshd-plugin is actually vulnerable).

If a vulnerability affects a plugin, the security team knows about it in advance and publishes an advisory. No advisory has been published.

I cut a release nevertheless, because people tend to panic and trust scanners more than proper evaluations.

@famod
Copy link

famod commented Nov 29, 2022

I cut a release nevertheless, because people tend to panic and trust scanners more than proper evaluations.

Thanks and you do have a point.

No pressure from my side!
I was about to add this CVE to my .trivyignore because I have sshd-plugin installed only because of dependency issues (which I have yet to analyze in detail) and SSH server is disabled, so my instance really shouldn't be vulnerable either way.

@MarkEWaite
Copy link
Contributor

@NotMyFault AFAICS, this will fix https://access.redhat.com/security/cve/CVE-2022-45047 (TBH, I haven't checked whether sshd-plugin is actually vulnerable). Are you going to cut a release anytime soon? Thanks!

The vulnerability scanner that reported this would resolve a CVE is incorrect. It indicates that the vulnerability scanner probably does not understand Jenkins plugin dependencies as expressed in pom.xml. When one Jenkins plugin depends on another Jenkins plugin, the dependency is resolved at Jenkins runtime by the currently loaded Jenkins plugin. Changing the plugin dependencies of a plugin mandates that the dependency must have at least the version specified. If there is a security is in the dependency, the Jenkins administrator resolves it by installing the plugin version that fixes the security issue.

@famod
Copy link

famod commented Nov 29, 2022

@MarkEWaite thanks for pointing that out!

I was actually surprised by the trivy report because my instance is already using Mina SSHD API :: Common Version 2.9.2-50.va_0e1f42659a_a.
My verdict for now is that it doesn't make that much sense to scan java libs in a Jenkins image via trivy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants