Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dead store to set the keyPairProvider #119

Merged
merged 1 commit into from
Feb 7, 2023

Conversation

MarkEWaite
Copy link
Contributor

Remove dead store to set the keyPairProvider

No need to set the keyPairProvider to a default value then immediately set it to a different value.

Storing once should be enough.

Detect as the only production use of SimpleGeneratorHostKeyProvider in the Jenkins code base while investigating for jenkinsci/jenkins#7623

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

No need to set the keyPairProvider to a default value
then immediately set it to a different value.

Storing once should be enough.
@timja timja merged commit 9c3e6dd into main Feb 7, 2023
@timja timja deleted the remove-dead-store-to-keyPairProvider branch February 7, 2023 11:06
@daniel-beck
Copy link
Member

Unused import remains.

@MarkEWaite MarkEWaite mentioned this pull request Mar 1, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants