Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated getPassword() #354

Merged
merged 1 commit into from
Sep 2, 2023

Conversation

offa
Copy link
Contributor

@offa offa commented Sep 1, 2023

Replaces the deprecated call to getPassword().

Testing done

Submitter checklist

Preview Give feedback

@offa offa requested a review from a team as a code owner September 1, 2023 11:10
Copy link
Contributor

@sghill sghill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution!

Looks like this method has been deprecated since jenkinsci/jenkins@f103b78, first included in Jenkins 2.222.1 (March 2020). I think it'd be a good candidate for an automated refactoring recipe in OpenRewrite/rewrite-jenkins if you wanted to apply this more broadly.

@sghill sghill added the internal label Sep 2, 2023
@sghill sghill merged commit ba2beb8 into jenkinsci:release/1.x Sep 2, 2023
@offa offa deleted the deprecated_method branch September 3, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants