Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API to supersede components if not required #601

Merged
merged 12 commits into from
Jan 2, 2025
Merged

API to supersede components if not required #601

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
736c267
adding feature to superceed componets if not required
nevingeorgesunny Dec 10, 2024
7c6567b
Update src/main/java/com/cloudbees/jenkins/support/api/Component.java
nevingeorgesunny Dec 19, 2024
329684a
pr comment suggestions
nevingeorgesunny Dec 19, 2024
0ed4bf8
adding test case
nevingeorgesunny Dec 19, 2024
d9ad2d8
Merge branch 'master' into superced-components
nevingeorgesunny Dec 19, 2024
21f0da1
updating comment
nevingeorgesunny Dec 19, 2024
bb180f7
removing test code
nevingeorgesunny Dec 19, 2024
8b1c11c
updating comments
nevingeorgesunny Dec 19, 2024
2461ef6
updating comments
nevingeorgesunny Dec 19, 2024
866d5bd
updating comments
nevingeorgesunny Dec 19, 2024
f6198d7
mvn spotless apply
nevingeorgesunny Dec 19, 2024
25dca3c
pr comment suggestions
nevingeorgesunny Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/main/java/com/cloudbees/jenkins/support/SupportPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -596,8 +596,13 @@

manifest.append("Requested components:\n\n");
ContentContainer contentsContainer = new ContentContainer(contentFilter, components);
Set<Class<? extends Component>> supersededComponents = new HashSet<>();
components.forEach(c -> supersededComponents.addAll(c.getSupersededComponents()));
for (Component component : components) {
try {
if (supersededComponents.contains(component.getClass())) {

Check warning on line 603 in src/main/java/com/cloudbees/jenkins/support/SupportPlugin.java

View check run for this annotation

ci.jenkins.io / Code Coverage

Partially covered line 

Line 603 is only partially covered, one branch is missing
continue;

Check warning on line 604 in src/main/java/com/cloudbees/jenkins/support/SupportPlugin.java

View check run for this annotation

ci.jenkins.io / Code Coverage

Not covered line 

Line 604 is not covered by tests
}
manifest.append(" * ").append(component.getDisplayName()).append("\n\n");
LOGGER.log(Level.FINE, "Start processing " + component.getDisplayName());
long startTime = System.currentTimeMillis();
Expand Down
4 changes: 4 additions & 0 deletions src/main/java/com/cloudbees/jenkins/support/api/Component.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,10 @@ public ComponentCategory getCategory() {
return ComponentCategory.UNCATEGORIZED;
}

public Set<Class<? extends Component>> getSupersededComponents() {
return Collections.emptySet();
}

/**
* Categories supported by this version of support-core
*
Expand Down
Loading