Migrate tests to JUnit5 #632
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strangelookingnerd
force-pushed
the
migrate_to_junit5
branch
from
52eddfd to
cd921d0
Compare
|
Looking at the failed tests I'm a little confused to be honest. Not sure how my changes could have affected the test results here. I will try to investigate a little further. |
* Migrate annotations and imports * Migrate assertions * Remove public visibility for test classes and methods * Minor code cleanup
strangelookingnerd
force-pushed
the
migrate_to_junit5
branch
from
cd921d0 to
bc2746b
Compare
|
Tests in this plugin, especially on Windows, are in a state of flux given the recent infrastructure changes. I would not advise any refactorings on this plugin’s tests until the existing tests are stable. (I also personally do not plan to spend any time reviewing JUnit 5 migration PRs. If there are any other active maintainers, they can feel free.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to migrate all tests to JUnit5. Changes include:
There are two exceptions where a migration was not possible as the tests rely on
Ruleimplementations that have not (yet) been migrated to JUnit5:SupportAutomatedBundleConfigurationSystemPropertiesTestusingRealJenkinsRuleSlaveLaunchLogsTestusingInboundAgentRuleI am well aware that this is a quite large changeset however I hope that there is still interest in this PR and it will be reviewed.
If there are any questions, please do not hesitate to ping me.