Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plan and build custom fields support #20

Merged
merged 7 commits into from
Apr 16, 2016

Conversation

maiksaray
Copy link

implemented support for testplan custom fields during iterative build steps
build requires testlink-java-api version 1.9.13-3 and higher (with kinow/testlink-java-api#60 accepted )

@jenkinsadmin
Copy link
Member

Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests.

@kinow
Copy link
Member

kinow commented Apr 16, 2016

Was going to release a new version with just testlink-java-api 1.9.14-0, but @maiksaray made sure to update this pull request and the code is looking very neat. Any comments added are either notes to myself to fix/massage some code after merging, or in case you'd like some feedback.

<description>This plug-in integrates Jenkins to TestLink</description>
<artifactId>testlink</artifactId>
<name>Jenkins TestLink Plugin</name>
<version>3.13-SNAPSHOT</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version value is changed by maven-release-plugin. When I run mvn clean release:prepare it runs the tests, does some other checks like git status and also asks for the next release version. Will fix it after merging.

@kinow kinow merged commit fb3ce3c into jenkinsci:master Apr 16, 2016
kinow added a commit that referenced this pull request Apr 16, 2016
@kinow
Copy link
Member

kinow commented Apr 16, 2016

Merged. Added to release notes for 3.12 in the Wiki https://wiki.jenkins-ci.org/display/JENKINS/TestLink+Plugin

Thanks!

@maiksaray
Copy link
Author

Thank you again for the work you do!

@kinow
Copy link
Member

kinow commented Apr 18, 2016

And thanks for your contribution @maiksaray ! Keep it coming, and I'll try my best to keep the pace and release early, release often ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants