Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add French i18n and fix translation messages #206

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

ymougenel
Copy link
Contributor

Hello,
I added a french translation for the plugin. While doing so I also noticed that some translation properties where not entirely set.
Therefore I moved the properties into the main folder:

Before:
image

After properties moved:
image

Testing done

Run all unit tests
Switch the browser between French,English and Japanese in order to check the translations

Tasks

Preview Give feedback
No tasks being tracked yet.

@ymougenel ymougenel requested a review from a team as a code owner November 6, 2023 21:45
@ymougenel
Copy link
Contributor Author

Please let me know if you see any improving points on this MR :-)

@ymougenel
Copy link
Contributor Author

Hello, any feedbacks on this MR?

Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@basil basil merged commit 4161a85 into jenkinsci:master Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants