Use the browser's timezone by default #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StevenGBrown
requested changes
May 7, 2018
|
|
||
| setCookie(mode); | ||
| setCookie('true', 'local'); | ||
| } |
| if (mode == 'local') { | ||
| options[mode].checked = true; | ||
| mode = 'system'; | ||
| } | ||
| modes[mode].checked = true; | ||
|
|
||
| // Renew the cookie. | ||
| setCookie(mode); |
There was a problem hiding this comment.
Not sure this should have been removed? It was there to auto-renew the cookie, so that it only expires if the page has not been visited in 2 years as in https://googleblog.blogspot.com.au/2007/07/cookies-expiring-sooner-to-improve.html
Previously, we would default to 'system clock time' when no cookies were set. Users would see UTC time unless they explicitly opted in to the browser timezone. This only impacts new users, or when the cookie expires.
Wilfred
force-pushed
the
local_timezone_by_default
branch
from
b8b594f to
b403d8e
Compare
StevenGBrown
approved these changes
May 9, 2018
|
Thanks! |
|
Fixed included in Timestamper 1.8.10 which will be available shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we would default to 'system clock time' when no cookies
were set. Users would see UTC time unless they explicitly opted in to
the browser timezone.
This only impacts new users, or when the cookie expires.